-
Notifications
You must be signed in to change notification settings - Fork 543
Add transformation boundary condition #3402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
connoramoreno
wants to merge
26
commits into
openmc-dev:develop
Choose a base branch
from
connoramoreno:transformation-bc
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add transformation boundary condition #3402
connoramoreno
wants to merge
26
commits into
openmc-dev:develop
from
connoramoreno:transformation-bc
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a transformation boundary condition to surfaces through which the user can define affine transformations to particle position and direction upon crossing the surface.
Mathematically, each affine transformation$\textbf{v} \rightarrow \textbf{v}'$ can be expressed as
where$A$ is a $3 \times 3$ matrix representing a linear map and $\textbf{b}$ is a vector of length 3 representing a translation. This transformation can be described in a single matrix-vector product via an augmented matrix and augmented vector:
where$\textbf{a}_i$ is the $i^{th}$ column of $A$ . I'll refer to this 3x4 augmented matrix $[A | \textbf{b}]$ as an "affine transformation matrix".
In the Python API, the affine transformations are defined by a keyword argument
transformation
of theSurface
class that is used only ifboundary_type == "transformation"
.transformation
takes the form of a dictionary with two optional keys:"direction"
: the affine transformation matrix modifying particle direction, given in row-major order"position"
: the affine transformation matrix modifying particle position, given in row-major orderWhen$[\mathbb{I}_3 | \textbf{0}_3]$ , where $\mathbb{I}_3$ is the $3 \times 3$ identity matrix and $\textbf{0}_3$ is the length-3 zero vector.
boundary_type == "transformation"
, for each key that is not provided, the affine transformation matrix is defined asA single regression test,
transformation_plane
has been added that mimics thereflective_plane
test, replacing the reflective BCs with transformation BCs that apply those same reflections. The expected results file is copied directly from thereflective_plane
directory. I can add additional regression tests that mimic the periodic BC tests for more robust testing.Fixes #3394
Checklist