Fixes and corrections #13
Merged
+118
−103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NexiusTailer
force-pushed
the
master
branch
12 times, most recently
from
2be6cdc to
cb5c820
Compare
There was a problem hiding this comment.
Pull request overview
This PR addresses several important fixes and formatting corrections to align the codebase with the original PAWN repository style:
- Fixes a critical bug in the
memcpyfunction where the offset was incorrectly applied to the source pointer instead of the destination pointer, potentially causing out-of-bounds reads - Corrects indentation throughout the
strinsfunction from 4 spaces to 2 spaces for consistency with the rest of the codebase - Re-adds a missing comment and fixes a typo in a comment describing cell size
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| source/amx/amxstring.c | Fixes critical bug in memcpy (offset now applied to destination instead of source); fixes indentation in strins function from 4 spaces to 2 spaces |
| source/amx/amxfloat.c | Removes extraneous blank line between comment and code in n_floatfract |
| source/amx/amxfile.c | Re-adds missing comment in flength function; adjusts spacing for consistency |
| source/amx/amxcore.c | Minor spacing adjustments in function signatures and parameters for consistency |
| source/amx/amx.h | Fixes typo in comment ("32-bit cells" → "64-bit cells" for __64BIT__ case); reformats multi-line comment to single line |
| source/amx/amx.c | Minor spacing adjustments around operators and in blank lines for consistency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
I'm sorry for not creating a new PR and adding more stuff here, but it's quite tiny if proposing separately:
|
NexiusTailer
force-pushed
the
master
branch
6 times, most recently
from
28cbd70 to
321f1e4
Compare
Southclaws
reviewed
Jan 11, 2026
Comment on lines
+33
to
+35
| native bool: fcopy(const source[], const target[]); | ||
| native bool: frename(const oldname[], const newname[]); | ||
| native bool: fcreatedir(const name[]); |
Contributor
There was a problem hiding this comment.
are these implemented in the amx runtime omp uses too?
Southclaws
approved these changes
Jan 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes are made in Pawn VM only (not in the compiler):
memcpyfunction: the change was made in this commit, so now offset is applied tosourceinstead ofdest. This way, the functionmemcpyin omp server still have bounds checking for destination array only, and we could be reading out of bounds from the source array if we set invalidindexparameterstrinsfunction. There should be 2 spaces instead of 4 like everywhere elseflengthwhich was in original repo previously, fix typo in comment for "PAWN_CELL_SIZE 64"Most of format tweaks were made on purpose, to reduce unnecessary differences in diff checker when comparing it with other forks based on original Pawn repo.