NPC Component (WIP) #916

AmyrAhmady · 2024-04-17T02:58:47Z

Info

This PR is made to follow progress of NPC component development
Also creating this PR allows our build CIs to run so people can grab server builds from this PR to test NPCs

(Note: Some stuff are taken from this branch https://github.com/openmultiplayer/open.mp/tree/Alasnkz/npc like NPC network class and some move calculations)

Current Pawn scripting API

Natives:

native NPC_Create(const name[]);
native NPC_Destroy(npcid);
native NPC_IsValid(npcid);
native NPC_Spawn(npcid);
native NPC_SetPos(npcid, Float:x, Float:y, Float:z);
native NPC_GetPos(npcid, &Float:x, &Float:y, &Float:z);
native NPC_SetRot(npcid, Float:x, Float:y, Float:z);
native NPC_GetRot(npcid, &Float:x, &Float:y, &Float:z);
native NPC_SetFacingAngle(npcid, Float:angle);
native NPC_GetFacingAngle(npcid, &Float:angle);
native NPC_SetVirtualWorld(npcid, vw);
native NPC_GetVirtualWorld(npcid, &vw);
native NPC_Move(npcid, Float:x, Float:y, Float:z, moveType, Float:moveSpeed = -1.0);
native NPC_StopMove(npcid);
native bool:NPC_IsMoving(npcid);
native NPC_SetSkin(npcid, model);
native NPC_IsStreamedIn(npcid, playerid);
native NPC_IsAnyStreamedIn(npcid);
native NPC_GetAll(npcs[], size = sizeof(npcs));
native NPC_SetInterior(npcid, interiorid);
native NPC_GetInterior(npcid);
native NPC_SetHealth(npcid, Float:health);
native Float:NPC_GetHealth(npcid);
native NPC_SetArmour(npcid, Float:armour);
native Float:NPC_GetArmour(npcid);
native NPC_ApplyAnimation(npcid, const animLib[], const animName[], Float:delta, bool:loop, bool:lockX, bool:lockY, bool:freeze, time, sync);
native NPC_SetWeapon(npcid, weapon);
native NPC_GetWeapon(npcid);
native NPC_SetAmmo(npcid, ammo);
native NPC_GetAmmo(npcid);
native NPC_SetKeys(npcid, upAndDown, leftAndRight, keys);
native NPC_GetKeys(npcid, &upAnddown, &leftandRight, &keys);
native NPC_MeleeAttack(npcid, time, bool:secondaryAttack = false);
native NPC_StopMeleeAttack(npcid);
native bool:NPC_IsMeleeAttacking(npcid);
native NPC_SetFightingStyle(npcid, style);
native NPC_GetFightingStyle(npcid);
native NPC_EnableReloading(npcid, bool:enable);
native bool:NPC_IsReloadEnabled(npcid);
native bool:NPC_IsReloading(npcid);
native NPC_EnableInfiniteAmmo(npcid, bool:enable);
native bool:NPC_IsInfiniteAmmoEnabled(npcid);
native NPC_GetWeaponState(npcid);
native NPC_SetAmmoInClip(npcid, ammo);
native NPC_GetAmmoInClip(npcid);
native NPC_Shoot(npcid, weapon, hitId, hitType, Float:endPointX, Float:endPointY, Float:endPointZ, Float:offsetX, Float:offsetY, Float:offsetZ, bool:isHit, checkInBetweenFlags);
native bool:NPC_IsShooting(npcid);
native NPC_AimAt(npcid, Float:pointX, Float:pointY, Float:pointZ, bool:shoot, shootDelay, bool:updateAngle, Float:offsetFromX, Float:offsetFromY, Float:offsetFromZ, checkInBetweenFlags);
native NPC_AimAtPlayer(npcid, playerid, bool:shoot, shootDelay, bool:updateAngle, Float:offsetX, Float:offsetY, Float:offsetZ, Float:offsetFromX, Float:offsetFromY, Float:offsetFromZ, checkInBetweenFlags);
native NPC_StopAim(npcid);
native bool:NPC_IsAiming(npcid);
native bool:NPC_IsAimingAtPlayer(npcid, playerid);
native NPC_SetWeaponAccuracy(npcid, weaponid, Float:accuracy);
native Float:NPC_GetWeaponAccuracy(npcid, weaponid);

Callbacks:

forward OnNPCFinishMove(npcid);
forward OnNPCCreate(npcid);
forward OnNPCDestroy(npcid);
forward OnNPCTakeDamage(npcid, damagerid, Float:damage, WEAPON:weapon, bodypart);
forward OnNPCGiveDamage(npcid, damagedid, Float:damage, WEAPON:weapon, bodypart);
forward OnNPCDeath(npcid, killerid, reason);
forward onNPCSpawn(npcid);
forwatd OnNPCWeaponStateChange(npcid, newState, oldState);

Videos:

Short video of basic usage:
https://cdn.discordapp.com/attachments/966398440051445790/1229681168878669895/ompnpc.mp4

eakwarp · 2024-04-17T08:39:24Z

Good job!
I'll try this on my walking npcs)

eakwarp · 2024-04-17T08:50:53Z

native NPC_StopMove(npcid, Float:x, Float:y, Float:z, moveType);


SCRIPT_API(NPC_StopMove, bool(INPC& npc))
{
	npc.stopMove();
	return true;
}

error in native?

ksenonadv · 2024-04-17T08:51:33Z

native NPC_StopMove(npcid, Float:x, Float:y, Float:z, moveType);
SCRIPT_API(NPC_StopMove, bool(INPC& npc))
{
	npc.stopMove();
	return true;
}
error in native?

Edited.

eakwarp · 2024-04-17T10:04:39Z

[2024-04-17T13:02:50+0300] [Info] [connection] incoming connection: 7f00:1:a4ff:ffff:a4ff:ffff:b94b:d7f7:63392 id: 0
[2024-04-17T13:02:50+0300] [Info] WalkNPC 0 Load, skin 31 node 2245
[2024-04-17T13:02:50+0300] [Info] [npc:part] FortCarson has left the server (0:2)
[2024-04-17T13:02:50+0300] [Info] [debug] Server crashed due to an unknown error

The first tests look interesting))

eakwarp · 2024-04-17T10:26:38Z

not bad not bad.)) 500 npc slots, 50 player slots))
Server crashed when i try to spawn npc in OnNPCConnect.

AmyrAhmady · 2024-04-17T10:36:27Z

I don't think NPCs are supposed to connect with ipv6 as your logs show
Also can you try using a cmd instead of spawning on connect? just to see if they work?

AmyrAhmady · 2024-04-17T10:40:48Z

not bad not bad.)) 500 npc slots, 50 player slots)) Server crashed when i try to spawn npc in OnNPCConnect.

Also, update your launcher!

eakwarp · 2024-04-17T10:51:39Z

I don't think NPCs are supposed to connect with ipv6 as your logs show Also can you try using a cmd instead of spawning on connect? just to see if they work?

I removed the spawn, the server is working, the npcs have connected, but are physically absent)

logs looks like good.

....
[2024-04-17T13:43:01+0300] [Info] [connection] incoming connection: 127.0.0.1:60194 id: 354
[2024-04-17T13:43:01+0300] [Info] [npc:join] FortCarson15 has joined the server (354:127.0.0.1)
[2024-04-17T13:43:01+0300] [Info] WalkNPC 355 Load, skin 191 node 4180
[2024-04-17T13:43:02+0300] [Info] [connection] incoming connection: 127.0.0.1:55540 id: 355
[2024-04-17T13:43:02+0300] [Info] [npc:join] FortCarson16 has joined the server (355:127.0.0.1)
[2024-04-17T13:43:02+0300] [Info] WalkNPC 356 Load, skin 226 node 4178
[2024-04-17T13:43:02+0300] [Info] [connection] incoming connection: 127.0.0.1:54902 id: 356
[2024-04-17T13:43:02+0300] [Info] [npc:join] FortCarson17 has joined the server (356:127.0.0.1)
[2024-04-17T13:43:02+0300] [Info] WalkNPC 357 Load, skin 248 node 4192
[2024-04-17T13:43:02+0300] [Info] [connection] incoming connection: 127.0.0.1:53290 id: 357
[2024-04-17T13:43:02+0300] [Info] [npc:join] FortCarson18 has joined the server (357:127.0.0.1)
[2024-04-17T13:43:02+0300] [Info] WalkNPC 358 Load, skin 261 node 4190
[2024-04-17T13:43:03+0300] [Info] [connection] incoming connection: 127.0.0.1:62594 id: 358
[2024-04-17T13:43:03+0300] [Info] [npc:join] FortCarson19 has joined the server (358:127.0.0.1)
[2024-04-17T13:43:03+0300] [Info] WalkNPC 359 Load, skin 151 node 4166
[2024-04-17T13:43:03+0300] [Info] [connection] incoming connection: 127.0.0.1:49694 id: 359
[2024-04-17T13:43:03+0300] [Info] [npc:join] Civilian has joined the server (359:127.0.0.1)
[2024-04-17T13:43:03+0300] [Info] WalkNPC 362 Load, skin 35 node 4218
....

Also, update your launcher!

later )

ipv6

ipv6 turns into a localhost after the first player connects, hm..)

[2024-04-17T13:41:29+0300] [Info] [connection] incoming connection: 7f00:1:fcdb:afff:7ce0:afff:9db:afff:58068 id: 55
[2024-04-17T13:41:29+0300] [Info] [npc:join] WillowField4 has joined the server (55:7f00:1:fcdb:afff:7ce0:afff:9db:afff)
[2024-04-17T13:41:29+0300] [Info] WalkNPC 55 Load, skin 48 node 510
[2024-04-17T13:41:29+0300] [Info] [connection] incoming connection: **7f00:1:fcdb:afff:7ce0:afff:9db:afff:56960 id: 56**
[2024-04-17T13:41:29+0300] [Info] [npc:join] SanPedro5 has joined the server (56:7f00:1:fcdb:afff:7ce0:afff:9db:afff)
[2024-04-17T13:41:29+0300] [Info] WalkNPC 56 Load, skin 236 node 520
[2024-04-17T13:41:29+0300] [Info] [connection] incoming connection: [censored]:14169 id: 57
**[2024-04-17T13:41:29+0300] [Info] [join] Richard_Castle has joined the server (57:[censored])**
[2024-04-17T13:41:29+0300] [Info] [connection] incoming connection: **127.0.0.1:61243 id: 58**
[2024-04-17T13:41:29+0300] [Info] [npc:join] SanPedro6 has joined the server (58:127.0.0.1)
[2024-04-17T13:41:29+0300] [Info] WalkNPC 57 Load, skin 192 node 530
[2024-04-17T13:41:30+0300] [Info] [connection] incoming connection: 127.0.0.1:62777 id: 59
[2024-04-17T13:41:30+0300] [Info] [npc:join] SanPedro7 has joined the server (59:127.0.0.1)
[2024-04-17T13:41:30+0300] [Info] WalkNPC 58 Load, skin 190 node 540
[2024-04-17T13:41:30+0300] [Info] [connection] incoming connection: 127.0.0.1:54810 id: 60
[2024-04-17T13:41:30+0300] [Info] [npc:join] SanPedro8 has joined the server (60:127.0.0.1)

eakwarp · 2024-04-17T11:06:03Z

[2024-04-17T14:04:29+0300] [Info] npc 0 spawned via timer
[2024-04-17T14:04:29+0300] [Info] npc 0 walk start timer
[2024-04-17T14:04:29+0300] [Info] [npc:part] FortCarson has left the server (0:2)
[2024-04-17T14:04:29+0300] [Info] [debug] Server crashed due to an unknown error

I tried to spawn NPCs 10 seconds after connecting - the server also crashed

eakwarp · 2024-04-17T11:27:57Z

One more bug, in OnNPCConnect(npcid)
npcid always 0

AmyrAhmady · 2024-04-20T10:07:23Z

As we talked in discord, regarding the crash issue, it should be fixed now. @eakwarp was kicking them and kicking an NPC wasn't implemented since it was on network level. Also removing/destroying NPCs on connect callbacks would result into crashes as well, which is now fixed too.

Also callback names are updated

eakwarp · 2024-08-08T22:13:47Z

what about new builds?)

AmyrAhmady · 2024-10-20T03:00:10Z

AmyrAhmady · 2025-02-04T07:07:11Z

There may be an error here, the npcid for which the key calls are applied is not specified.

native NPC_SetKeys(upAndDown, leftAndRight, keys); native NPC_GetKeys(&upAnddown, &leftandRight, &keys);

Thanks

douq · 2025-03-02T20:21:03Z

any chance to get FCNPC_Respawn() soon? :)

AmyrAhmady · 2025-03-02T20:22:24Z

any chance to get FCNPC_Respawn() soon? :)

Is it not possible to just call NPC_Spawn again?

douq · 2025-03-02T21:17:45Z

@AmyrAhmady: Yes, you're right.

I tested the latest build of the NPC component with this script: https://pastebin.com/62zSMpSq.

I'm not sure if I'm just being stupid or if there are actual bugs:

If I create an NPC in a filterscript and load it, everything works fine. But if I reload the filterscript, the NPC connects and immediately disconnects.
I can't seem to damage the NPC, or he never dies. Do I need to manually calculate its death or handle something else? If I use NPC_SetHealth(0.0) he dies.
The NPC doesn't shoot when I use the /shoot command above. He just aims at me. Could the shooting delay be too short or too long or is it just a bug?
I think the angle calculation during NPC aiming is incorrect. He isn't aiming directly at me (see screenshot).

Is this the correct way to report these issues/questions, or should I use Discord instead?

Thanks!

douq · 2025-04-13T15:48:00Z

Following up on my post above: When I spawn two NPCs, I can kill one, but the other becomes invulnerable. It doesn’t matter which one I kill — the remaining NPC always becomes invulnerable.

Would it be possible to add OnNPCWeaponShot?

midosvt · 2025-04-16T02:08:06Z

Typo.

Callbacks:

forwatd OnNPCWeaponStateChange(npcid, newState, oldState);

Woet · 2025-05-30T05:40:20Z

Sometimes NPCs will connect but not physically show up in-game. This seems to be related to them using a playerID that has been used by a player before. All functions still work, they still show up in the logs the same as all the other ones, and NPC_SetPos -> NPC_GetPos are in sync. If I run the command below 20 times, maybe 5-10 of them will show up.

COMMAND:npccreate(playerid, params[]){	
	// Get nickname
	format(iStr, sizeof(iStr), "NPC_%d", NPC_number);
	NPC_number++;

	// Create it
	new npcid = NPC_Create(iStr);
	NPC_Spawn(npcid);
	NPC_SetPos(npcid, 1368.7627, -1089.5592, 24.3783);
	NPC_EnableInfiniteAmmo(npcid, true);
	NPC_SetAmmo(npcid, 100);
	NPC_SetHealth(npcid, 10.0);
	NPC_SetWeapon(npcid, NPC_weapon);

	return 1;
}

NPCs do not receive or give damage. You can shoot them, even on 10 HP, and nothing will happen. They will also shoot, and nearly all of the bullets will hit and show blood on the target, but no damage is being done to them.

function:NPCShootPlayer(playerid){
	new Float:x, Float:y, Float:z;

	GetPlayerPos(playerid, x, y, z);

	foreach(new i : NPCs){
		NPC_Shoot(i, NPC_weapon, playerid, 1, x, y, z, 0.0, 0.0, 0.0, true, true);
	}
}

And lastly, I think it'd be a good idea if these were threaded, similar to the native NPCs using samp-npc.exe. Most high population servers already struggle with the fact the AMX thread is single core, so adding a few hundred NPCs with advanced logic will definitely cause some issues.

AmyrAhmady added the draft label Apr 17, 2024

AmyrAhmady self-assigned this Apr 17, 2024

AmyrAhmady changed the title ~~NPC Component~~ NPC Component (WIP) Apr 17, 2024

AmyrAhmady force-pushed the amir/NPCs branch from b0ca100 to 612341a Compare April 23, 2024 12:01

AmyrAhmady force-pushed the amir/NPCs branch 2 times, most recently from 7d97857 to 5ad4db9 Compare October 18, 2024 05:23

ziggi mentioned this pull request Jan 11, 2025

Open Mp ziggi/FCNPC#294

Closed

AmyrAhmady force-pushed the amir/NPCs branch from 0ee0f1a to af5a621 Compare January 28, 2025 15:08

AmyrAhmady added 9 commits January 31, 2025 09:38

continue onReceive event calls if Recording component has failure

e37329e

create NPCs component

cc04361

create pawn scripting api for current NPC functions

46759c4

force internal updates on position and rotation change

7ad704a

calculate travelled distance once

120955d

add NPC_StopMove

6edef7e

restart npc move when pos or rot is reset

7e0f21d

only start npc move if move type is valid

49e9b94

set internal rot and pos values during move to avoid recursion

bc6c6eb

AmyrAhmady added 6 commits February 4, 2025 10:21

add aiming feature and finish shooting mechanism

b79f747

add npc.globalUpdareRate config

b000574

fix formatting

629aa4e

add aiming pawn natives

7463ba3

fix NPC_AimAtPlayer definition

7a79654

add OnNPCSpawn pawn callback

970eaa9

AmyrAhmady added 4 commits February 4, 2025 15:26

fix typo and update time indicator issue

b55565b

set ipv6 to false for npcs

b29015b

add set and get weapon accuracy

f4e9095

add moveSpeed to npc move

e1b2a63

AmyrAhmady force-pushed the amir/NPCs branch from c2cc6d4 to e1b2a63 Compare February 5, 2025 09:29

AmyrAhmady added 3 commits February 5, 2025 16:05

check if npc is valid in damage callbacks

bbe006d

enter and exit vehicle

d035b35

NPC_IsMoving, NPC_EnterVehicle, NPC_ExitVehicle

d092f09

fix destroyed NPC IDs not being able to be used again

a5e60d3

AmyrAhmady force-pushed the amir/NPCs branch 2 times, most recently from 6bda100 to 69d38ae Compare March 4, 2025 19:32

update SDK

45bf1fd

AmyrAhmady force-pushed the amir/NPCs branch from 69d38ae to 45bf1fd Compare March 4, 2025 19:34

AmyrAhmady added 4 commits March 4, 2025 23:58

use setWeaponState in updateWeaponState

7c505c6

fix player rotation when aiming

7a57ac7

fix shooting, still weird it's not hitting, but at least it shoots

a27c282

small changes in update counter, sending aimsync (maybe broken)

5e8d1b0

NPC Component (WIP) #916

Are you sure you want to change the base?

NPC Component (WIP) #916

Uh oh!

Conversation

AmyrAhmady commented Apr 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Info

Current Pawn scripting API

Natives:

Callbacks:

Videos:

Uh oh!

eakwarp commented Apr 17, 2024

Uh oh!

eakwarp commented Apr 17, 2024

Uh oh!

ksenonadv commented Apr 17, 2024

Uh oh!

eakwarp commented Apr 17, 2024

Uh oh!

eakwarp commented Apr 17, 2024

Uh oh!

AmyrAhmady commented Apr 17, 2024

Uh oh!

AmyrAhmady commented Apr 17, 2024

Uh oh!

eakwarp commented Apr 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eakwarp commented Apr 17, 2024

Uh oh!

eakwarp commented Apr 17, 2024

Uh oh!

AmyrAhmady commented Apr 20, 2024

Uh oh!

eakwarp commented Aug 8, 2024

Uh oh!

AmyrAhmady commented Oct 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AmyrAhmady commented Feb 4, 2025

Uh oh!

douq commented Mar 2, 2025

Uh oh!

AmyrAhmady commented Mar 2, 2025

Uh oh!

douq commented Mar 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

douq commented Apr 13, 2025

Uh oh!

midosvt commented Apr 16, 2025

Callbacks:

Uh oh!

Woet commented May 30, 2025

Uh oh!

Uh oh!

AmyrAhmady commented Apr 17, 2024 •

edited

Loading

eakwarp commented Apr 17, 2024 •

edited

Loading

AmyrAhmady commented Oct 20, 2024 •

edited

Loading

douq commented Mar 2, 2025 •

edited

Loading