Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fetch cache does not depend on tag cache being enabled #684

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Dec 20, 2024

That should help with opennextjs/opennextjs-cloudflare#194

Copy link

changeset-bot bot commented Dec 20, 2024

🦋 Changeset detected

Latest commit: 61ddeaa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@opennextjs/aws Patch
app-pages-router Patch
app-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vicb vicb requested a review from conico974 December 20, 2024 10:16
Copy link

pkg-pr-new bot commented Dec 20, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/aws@684

commit: 61ddeaa

Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 23.26% 1761 / 7570
🔵 Statements 23.26% 1761 / 7570
🔵 Functions 56.83% 104 / 183
🔵 Branches 71.33% 448 / 628
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/open-next/src/build/createAssets.ts 0% 0% 0% 0% 1-248
Generated in workflow #843 for commit 61ddeaa by the Vitest Coverage Report Action

Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks.
FYI at the moment there is no way to manually invalidate a fetch cache entry without the tag cache

@vicb vicb merged commit 9595714 into main Dec 20, 2024
3 checks passed
@vicb vicb deleted the fetch-cache branch December 20, 2024 12:33
@vicb
Copy link
Contributor Author

vicb commented Dec 20, 2024

Thanks for all the reviews today :)

@github-actions github-actions bot mentioned this pull request Dec 20, 2024
@vicb
Copy link
Contributor Author

vicb commented Dec 20, 2024

FYI at the moment there is no way to manually invalidate a fetch cache entry without the tag cache

We will work on the tag cache next. Hopefully early next year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants