Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate e2e failures #291

Open
vicb opened this issue Jan 28, 2025 · 0 comments
Open

Investigate e2e failures #291

vicb opened this issue Jan 28, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@vicb
Copy link
Contributor

vicb commented Jan 28, 2025

This repo imported the e2e tests from @opennextjs/aws into examples/e2e.

The unit tests can be executed by pnpm e2e-fix

We need to investigate the e2e failures

  • Some are expected - i.e. ISR is not supported yet
  • Some are not expected

Notes:

The pages-router and app-pages-router both have a build issue to investigate:

[WebServer] ▲ [WARNING] Using direct eval with a bundler is not recommended and may cause problems [direct-eval]
[WebServer] 
[WebServer]     .open-next/server-functions/default/examples/e2e/pages-router/handler.mjs:193620:43:
[WebServer]       193620 │ ...         var deprecatedfn = eval("(function (" + args + ') ...

Related PRs:

Next steps:

For each of app-router, pages-router, and app-pages-router in examples/e2e:

  • run pnpm e2e-fix
  • create sub-issue here for failing tests, skip the related test and comment with the issue:
// from

test("some failing test", () => {...});

// to

// https://github.com/opennextjs/opennextjs-cloudflare/issues/...
test.skip("some failing test", () => {...});
  • once all failing tests are skip, we can rename the e2e-fix script to e2e
  • then we should prioritize and tackle the sub issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

1 participant