Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: import app-router e2e tests from aws #289

Merged
merged 1 commit into from
Jan 28, 2025
Merged

test: import app-router e2e tests from aws #289

merged 1 commit into from
Jan 28, 2025

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Jan 28, 2025

Run the tests with pnpm -F app-router e2e-fix

Note that the script is named e2e-fix so that it doesn't run on the CI yet as some tests are failing.

Some failures are expected (i.e. ISR) and some need to be investigated.

Copy link

changeset-bot bot commented Jan 28, 2025

⚠️ No Changeset found

Latest commit: e88aeb0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Jan 28, 2025

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@289

commit: e88aeb0

Copy link
Contributor

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I don't see the point in introducing this with the e2e-fix script that doesn't run in CI, I think that it should instead have a normal e2e script but the incompatible tests get properly skipped (potentially with todo comments and respective gh issues)

I'm approving as the PR in its intended state look correct to me

@vicb
Copy link
Contributor Author

vicb commented Jan 28, 2025

Personally I don't see the point in introducing this with the e2e-fix script that doesn't run in CI, I think that it should instead have a normal e2e script but the incompatible tests get properly skipped (potentially with todo comments and respective gh issues)

Agreed, that is the next step, there is already an issue for that at #291. We should create sub-issue for tests that we will skip and investigate them.

Thanks for the review

@vicb vicb merged commit e4285a7 into main Jan 28, 2025
7 checks passed
@vicb vicb deleted the test/app-router branch January 28, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants