fix: host not included in route handler urls #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5cee06c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
james-elicx
commented
Jan 8, 2025
commit: |
james-elicx
force-pushed
the
james/fix-missing-host-route-handler
branch
from
94c515a to
5cee06c
Compare
|
@conico974 could you please take a look when you have time? Thanks! |
I was also thinking that we might want to switch to not using external middleware at least until we have a better story for multi worker app. |
conico974
reviewed
Jan 8, 2025
This was referenced Jan 9, 2025
vicb
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #210
Research into what happens internally in Next.js is available in #210 (comment).
OpenNext is removing the
trustHostHeader: trueoption from the Next.js config if routing is disabled, and it considers routing disabled whenconfig.middleware.externalis truthy. This value is required to be true in the OpenNext config used for deploying to Cloudflare.This PR changes the check to not strip it if there is external middleware.