-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: migrate the requirePage patch to ast-grep #287
Conversation
|
commit: |
@james-elicx maybe actually this should rather be an ESBuild plugin as it would solve the issue for |
Added a commit to resolve external paths to absolute, ready for review! |
packages/cloudflare/src/cli/build/patches/plugins/wrangler-external.ts
Outdated
Show resolved
Hide resolved
packages/cloudflare/src/cli/build/patches/to-investigate/inline-next-require.ts
Show resolved
Hide resolved
packages/cloudflare/src/cli/build/patches/plugins/require-page.ts
Outdated
Show resolved
Hide resolved
Thanks for the very helpful review @dario-piotrowicz I added comments to clarify, PTAL! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates @vicb
Looks good to me 😄
@james-elicx I'd like to land that but there is one issue with og: it uses relative paths and that messes with the external in
bundle-server
.Could you add one more rule to convert relative path to absolute (in import function expressions)?
Thanks!