Skip to content

fix(installers): correct exit status on macOS bash 3.2 #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gorakhnathy7 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(installers): correct exit status on macOS bash 3.2 #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ai/lib/common.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,11 @@ cleanup_on_error() {
# but install_error_trap below replaces the EXIT trap — so we re-do the
# bootstrap cleanup here. macOS mktemp writes to /var/folders/, Linux to /tmp/.
cleanup_on_exit() {
# Capture the script's real exit status and re-exit with it below. On
# bash 3.2 (macOS /bin/bash) the status of the LAST command in an EXIT
# trap silently becomes the script's exit status — without this, the
# trailing `[ -f ... ]` test made every installer exit 1 even on success.
local exit_code=$?
if [ -n "${COMMON_SH:-}" ] && [ -f "$COMMON_SH" ]; then
case "$COMMON_SH" in
/tmp/*|/var/folders/*) rm -f "$COMMON_SH" ;;
Expand All @@ -135,6 +140,7 @@ cleanup_on_exit() {
for f in "${TEMP_FILES[@]:-}"; do
[ -f "$f" ] && rm -f "$f"
done
exit "$exit_code"
}

# Caller installs the trap via: install_error_trap
Expand Down