Skip to content

Remove nc from descriptions of OPS files #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 4, 2021

Conversation

dwhswenson
Copy link
Member

Files can also be .db. Change recommended as an aside in openpathsampling/mini-tutorials#5 (comment).

(since files can also be .db)
@codecov
Copy link

codecov bot commented Sep 3, 2021

Codecov Report

Merging #51 (4a8e50d) into main (8e71c33) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #51   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           29        29           
  Lines         1204      1204           
=========================================
  Hits          1204      1204           
Impacted Files Coverage Δ
paths_cli/commands/contents.py 100.00% <ø> (ø)
paths_cli/parameters.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e71c33...4a8e50d. Read the comment docs.

@dwhswenson
Copy link
Member Author

This is ready for review and comment. I will leave it open for at least 24 hours, merging no earlier than Sat 04 Sep 04:00 GMT (00:00 my local).

Copy link
Member

@sroet sroet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit unsure about the wording (it could also be used on an "input" file), but feel free to ignore. This LGTM otherwise

@dwhswenson
Copy link
Member Author

Thanks -- I like the suggestion of storage file. I had the same concerns, and had considered database file (but that's too close the to the .db suffix, making it sound SimStore-specific) and just file (but with the YAML/JSON/TOML input files that will be possible after #43, there's more than one kind of "OPS file" -- and the YAML/JSON/TOML files are definitely better thought of as "input," so don't want to use the word "input file"!)

"Storage file" finds the right balance. Going with that.

@dwhswenson dwhswenson merged commit 8217eea into openpathsampling:main Sep 4, 2021
@dwhswenson dwhswenson deleted the update-help branch September 4, 2021 07:41
@dwhswenson dwhswenson mentioned this pull request Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants