Add Hamcrest to AssertJ recipes for hasProperty, everyItem, and hasItem(Matcher)#916
Merged
Add Hamcrest to AssertJ recipes for hasProperty, everyItem, and hasItem(Matcher)#916
Conversation
…em(Matcher) Fixes #915 by adding three new recipes to handle previously unhandled Hamcrest matchers: - HamcrestHasPropertyToAssertJ: converts hasProperty() to hasFieldOrProperty() or hasFieldOrPropertyWithValue() - HamcrestEveryItemToAssertJ: converts everyItem() to hasOnlyElementsOfType() or allSatisfy() - HamcrestHasItemMatcherToAssertJ: converts hasItem(Matcher) to hasAtLeastOneElementOfType() or anySatisfy() Each recipe handles optional reason arguments and includes comprehensive tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Hamcrest to AssertJ unhandled cases (instanceOf, hasProperty and hasItem) #915 by adding three new recipes to handle previously unhandled Hamcrest matchers that were preventing full migration to AssertJ:
HamcrestHasPropertyToAssertJ: Converts
hasProperty()to AssertJ'shasFieldOrProperty()orhasFieldOrPropertyWithValue()HamcrestEveryItemToAssertJ: Converts
everyItem()tohasOnlyElementsOfType()forinstanceOfmatchers orallSatisfy()for general matchersHamcrestHasItemMatcherToAssertJ: Converts
hasItem(Matcher)tohasAtLeastOneElementOfType()forinstanceOfmatchers oranySatisfy()for general matchersAll three recipes support optional reason arguments and properly handle import management.
Test plan
MigrateHamcrestToAssertJcomposite recipe