Conversation
When a project only has PowerMock declared and gets Mockito transitively through powermock-api-mockito, ReplacePowerMockito removes the PowerMock dependencies but never adds mockito-core. Reproduces moderneinc/customer-requests#1926
…moving it When a project gets Mockito only transitively through powermock-api-mockito, RemoveDependency leaves no Mockito dependency at all. Instead of removing and then adding (which runs into stale GradleProject marker issues with AddDependency), use ChangeDependency to convert powermock-api-mockito directly to mockito-core:3.x. Handles both powermock-api-mockito (Mockito 1) and powermock-api-mockito2 (Mockito 2) artifact names. Fixes moderneinc/customer-requests#1926
timtebeek
approved these changes
Feb 27, 2026
github-project-automation
bot
moved this from In Progress
to Ready to Review
in OpenRewrite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RemoveDependencyforpowermock-api-mockito(2)withChangeDependencytomockito-core:3.xmockito-coredependencyProblem
When a project declares only PowerMock dependencies (e.g.,
powermock-api-mockito) and gets Mockito transitively,ReplacePowerMockitoremoves the PowerMock dependencies but never addsmockito-core. The parent recipes (Mockito1to3Migration, etc.) useChangeDependencyandUpgradeDependencyVersionwhich only act on existing dependencies, so they can't help either.Result: code uses Mockito APIs but has no Mockito dependency after the recipe runs.
Solution
Instead of removing
powermock-api-mockito/powermock-api-mockito2and hopingAddDependencyfills the gap, useChangeDependencyto directly convert these PowerMock API dependencies intomockito-core:3.x. This avoids the stale resolved-dependency model issue whereAddDependencysees mockito-core as still transitively available through the (about-to-be-removed) PowerMock dependency.RemoveDependencyis kept only forpowermock-core(which has no Mockito equivalent).Test plan
New integration test
addsMockitoCoreWhenOnlyTransitiveThroughPowerMock— fails before fix, passes afterAll existing
*PowerMockito*tests passAll
*Mockito1to3*,*Mockito1to4*,*Mockito1to5*migration tests passFull
./gradlew buildpassesFixes moderneinc/customer-requests#1926