Remove all remaining PowerMock dependencies in ReplacePowerMockito recipe#921
Merged
Remove all remaining PowerMock dependencies in ReplacePowerMockito recipe#921
Conversation
…cipe The ReplacePowerMockito recipe previously only removed powermock-api-mockito, powermock-api-mockito2, and powermock-core. This left behind 14 other org.powermock artifacts that should also be removed when migrating to Mockito. Added RemoveDependency entries for: powermock-api-support, powermock-api-mockito-common, powermock-api-easymock, powermock-reflect, powermock-module-junit4, powermock-module-junit4-common, powermock-module-junit4-legacy, powermock-module-junit4-rule, powermock-module-junit4-rule-agent, powermock-module-junit3, powermock-module-junit5, powermock-module-testng, powermock-classloading-xstream, and powermock-classloading-objenesis. Fixes moderneinc/customer-requests#1933
steve-aom-elliott
added
enhancement
Add RemoveManagedDependency entries alongside each RemoveDependency to ensure PowerMock artifacts are also cleaned up from Maven dependencyManagement sections.
Move all RemoveDependency and RemoveManagedDependency entries into a new RemovePowerMockDependencies declarative recipe for clarity. The main ReplacePowerMockito recipe now references it as a single entry.
Replace individual RemoveDependency and RemoveManagedDependency entries with a single powermock* glob for each, and inline back into the main ReplacePowerMockito recipe.
Verifies that RemoveManagedDependency with powermock* wildcard correctly removes managed PowerMock dependencies, and that ChangeDependency properly converts managed powermock-api-mockito into managed mockito-core. Fixes moderneinc/customer-requests#1933
bmuschko
reviewed
Feb 27, 2026
src/test/java/org/openrewrite/java/testing/mockito/ReplacePowerMockitoIntegrationTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/openrewrite/java/testing/mockito/ReplacePowerMockitoIntegrationTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/openrewrite/java/testing/mockito/ReplacePowerMockitoIntegrationTest.java
Show resolved
Hide resolved
…annotations Add a pomXml assertion to the existing Gradle test to verify PowerMock dependencies are removed from Maven builds without dependencyManagement. Remove @issue annotations referencing the customer-requests repo.
timtebeek
approved these changes
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RemoveDependencyandRemoveManagedDependencyentries to remove allorg.powermock:powermock*artifactsProblem
The
ReplacePowerMockitorecipe only removed 3 PowerMock artifacts (powermock-api-mockito,powermock-api-mockito2,powermock-core), leaving behind many others such aspowermock-module-junit4,powermock-reflect,powermock-api-support, etc.Solution
Added wildcard-based
RemoveDependencyandRemoveManagedDependencyentries (org.powermock:powermock*) to catch all PowerMock artifacts. The existingChangeDependencyentries remain to convertpowermock-api-mockito/powermock-api-mockito2tomockito-core.Test plan
removesAllPowerMockDependenciesverifies removal from both Gradle and Maven buildsremovesManagedPowerMockDependenciesverifies removal of Maven managed dependencies