fix(kotlin): Honor Retry-After for pool warmups - #1512
Merged
Pangjiping merged 3 commits intoAug 19, 2026
Merged
Conversation
Gujiassh
requested review from
Pangjiping,
hittyt,
jwx0925 and
ninan-nn
as code owners
August 14, 2026 04:06
github-actions
Bot
added
documentation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a499814066
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Pangjiping
reviewed
Aug 18, 2026
Fall back to the default warmup delay when Retry-After is zero or non-positive, and document that snapshot().backoffActive also covers the rate-limit throttle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SandboxRateLimitExceptionduring Kotlin pool warmup completion and pause new warmups forRetry-After, with a 10-second default and the existing 60-second SDK cap.The rate-limit state is scoped to the active pool run, avoiding a shared
PoolStateStorecontract change and keeping this fix separate from the windowed degraded-detection work in #1499.Fixes #1500.
Testing
./gradlew :sandbox:test(324 tests, 0 failures)Retry-Afterrecovery and stop/start reset tests./gradlew spotlessCheckpnpm docs:buildBreaking Changes
Checklist