Skip to content

fix(chart): default containerdSocketPath to empty and bump opensandbox chart to 0.2.2 - #1557

Open
hittyt wants to merge 5 commits into
opensandbox-group:mainfrom
hittyt:fix/chart-release-and-controller-socket-default
Open

fix(chart): default containerdSocketPath to empty and bump opensandbox chart to 0.2.2#1557
hittyt wants to merge 5 commits into
opensandbox-group:mainfrom
hittyt:fix/chart-release-and-controller-socket-default

Conversation

@hittyt

@hittyt hittyt commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

  1. Fix Controller `--containerd-socket-path` flag crash:
    • Default `controller.snapshot.containerdSocketPath` to `""` in `kubernetes/charts/opensandbox-controller/values.yaml`.
    • The Go controller binary defaults internally to `/var/run/containerd/containerd.sock` when the flag is omitted. Defaulting to `""` in chart values ensures `--containerd-socket-path` is not rendered by default, preventing `flag provided but not defined: -containerd-socket-path` CrashLoopBackOff when deploying with controller image `v0.2.0`.
  2. Bump all-in-one chart version to 0.2.2:
    • Update `version` and `appVersion` to `0.2.2` in `kubernetes/charts/opensandbox/Chart.yaml` and synchronize `Chart.lock`.
  3. Enhance CI & Makefile validation:
    • Update `make helm-lint` in `kubernetes/Makefile` to lint all subcharts and verify `helm dependency build` for the all-in-one chart.
    • Add `make helm-lint` step to `.github/workflows/kubernetes-test.yml` to prevent future `Chart.lock` out-of-sync release failures.
  4. Update docs:
    • Update tip in `docs/examples/aks-kata.md`.

Related Issue

Fixes #1529

@hittyt
fix(chart): default containerdSocketPath to empty and bump opensandbo…
45bbe5b 
…x chart to 0.2.2

- Set controller.snapshot.containerdSocketPath default to empty string to avoid crash-looping with v0.2.0 controller image
- Bump opensandbox all-in-one chart version and appVersion to 0.2.2
- Update aks-kata documentation note regarding containerdSocketPath
- Enhance kubernetes Makefile helm-lint target to lint all charts and verify dependencies
- Add helm-lint step in kubernetes-test CI workflow to prevent lockfile desynchronization
@github-actions github-actions Bot added component/k8s For kubernetes runtime documentation Improvements or additions to documentation size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 18, 2026
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Aug 18, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 45bbe5b40c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread kubernetes/charts/opensandbox-controller/values.yaml
@github-actions github-actions Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 18, 2026
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Aug 18, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4bb7ec3730

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/kubernetes/deployment.md
@hittyt

hittyt commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator Author

@codex /review

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Aug 18, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4bb7ec3730

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/publish-helm-chart.yml
@hittyt

hittyt commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator Author

@codex /review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 18, 2026

Copy link
Copy Markdown

Review Result

No additional actionable findings on commit d6dc9097e7e79f9403f7bc77bcaa76850588f972.

The current head addresses the earlier versioning concerns:

Checks

  • ✅ git diff --check ebb85d8e89fa6463a1d386e4642945a4e696b479..HEAD
  • ✅ git status --short
  • ⚠️ cd kubernetes && make helm-lint (not run successfully because Helm is unavailable in this environment: helm: command not found)

No code changes were necessary, so no commit or follow-up pull request was created.

View task →

fengcone
fengcone approved these changes Aug 18, 2026
View reviewed changes

@fengcone fengcone left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments
@fengcone fengcone fengcone approved these changes
@Spground Spground Awaiting requested review from Spground Spground is a code owner
@Generalwin Generalwin Awaiting requested review from Generalwin Generalwin is a code owner
@kevinlynx kevinlynx Awaiting requested review from kevinlynx kevinlynx is a code owner
@ninan-nn ninan-nn Awaiting requested review from ninan-nn ninan-nn is a code owner
@Pangjiping Pangjiping Awaiting requested review from Pangjiping Pangjiping is a code owner
@jwx0925 jwx0925 Awaiting requested review from jwx0925 jwx0925 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

component/k8s For kubernetes runtime documentation Improvements or additions to documentation size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Please consider publishing a new all-in-one Helm chart, the official chart artifact has been stuck on 0.1.0 (2026-03-05) for 5 months

2 participants

@hittyt @fengcone