Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add Star Tree unsigned-long indexing changes (#17156) #17161

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

Shailesh-Kumar-Singh
Copy link
Contributor

@Shailesh-Kumar-Singh Shailesh-Kumar-Singh commented Jan 28, 2025

Description

Backport of #17156

Related Issues

Resolves Issue - Handle unsigned long during flush and merge operations

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❕ Gradle check result for 0d7a7b5: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 89.69072% with 10 lines in your changes missing coverage. Please review.

Project coverage is 71.92%. Comparing base (f4acda3) to head (0d7a7b5).
Report is 3 commits behind head on 2.x.

Files with missing lines Patch % Lines
...be/startree/fileformats/meta/StarTreeMetadata.java 62.50% 4 Missing and 2 partials ⚠️
...h/index/compositeindex/datacube/ReadDimension.java 75.00% 2 Missing ⚠️
...rtree/fileformats/meta/StarTreeMetadataWriter.java 85.71% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #17161      +/-   ##
============================================
- Coverage     72.06%   71.92%   -0.15%     
+ Complexity    65875    65789      -86     
============================================
  Files          5325     5329       +4     
  Lines        306408   306463      +55     
  Branches      44701    44704       +3     
============================================
- Hits         220819   220410     -409     
- Misses        67188    67626     +438     
- Partials      18401    18427      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@linuxpi linuxpi merged commit de6b87b into opensearch-project:2.x Jan 28, 2025
71 of 73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants