Fix flaky test SegmentReplicationIT.testReplicaAlreadyAtCheckpoint #17216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sandeep Kumawat <[email protected]>
github-actions
bot
added
>test-failure
skumawat2025
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
cwperks,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli and
shwetathareja
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17216 +/- ##
============================================
- Coverage 72.34% 72.31% -0.03%
- Complexity 65731 65747 +16
============================================
Files 5318 5318
Lines 305743 305741 -2
Branches 44350 44350
============================================
- Hits 221182 221095 -87
- Misses 66394 66573 +179
+ Partials 18167 18073 -94 ☔ View full report in Codecov by Sentry. |
ashking94
reviewed
Jan 31, 2025
| @@ -1892,6 +1892,7 @@ public void testReplicaAlreadyAtCheckpoint() throws Exception { | |||
| // index a doc. | |||
| client().prepareIndex(INDEX_NAME).setId("1").setSource("foo", randomInt()).get(); | |||
| refresh(INDEX_NAME); | |||
| waitForSearchableDocs(1, primaryNode, replicaNode, replicaNode2); | |||
There was a problem hiding this comment.
At which step does the test fails? can you share more details about the failure (since i could not get that clearly from description)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the SegmentReplicationIT.testReplicaAlreadyAtCheckpoint test, we are creating three nodes with one primary node and two replica nodes. After ingesting documents to the primary shard, we are not checking if the segment replication to both replica 1 and 2 has finished. Without verifying this, we are stopping the primary node. This behavior leads to the test being flaky when the replication has not completed.
With this change we are ensuring replication has finished before stopping the primary node.
Related Issues
Resolves #14328
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.