Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test RemoteIndexRecoveryIT.testRerouteRecovery #17228

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sachinpkale
Copy link
Member

@sachinpkale sachinpkale commented Feb 3, 2025

Description

  • IndexRecoveryIT.testRerouteRecovery triggers shard movement and verifies few details while recovery is in progress. It also slows down recovery to make sure that shard is not moved before we assert.
  • When we extended RemoteIndexRecoveryIT extends IndexRecoveryIT`, we reduced number of docs to be ingested by 5x (this is to decrease test run time as latency of ingestion is higher with remote store enabled).
  • @Override
    protected int numDocs() {
    return randomIntBetween(100, 200);
    }
  • But we did not slowed down recovery by 5x. This leads to flaky behaviour in the test where recovery completes before we check recovery stats.
  • To avoid the flakiness, in this PR, we have slowed down recovery by 5X.

Related Issues

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Feb 3, 2025

❌ Gradle check result for 3a2e2f3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Feb 7, 2025

❌ Gradle check result for 3a2e2f3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant