fix explain action on query rewrite #17286
Open
+38
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is an exception when call explain in "by_doc_id" mode. Response looks like this:
The error were caught from
TransportExplainAction -> Rewriteable.java
because there still be asyncActions left when the flagassertNoAsyncTasks
returned as true.The conflict is down to:
The NeuralQueryBuilder or TermsQueryBuilder
doRewrite
method introduces asynchronous actions viaqueryRewriteContext.registerAsyncAction
. So it then returns a context with potentially unresolved async tasks.Rewritable.rewrite
then checksassertNoAsyncTasks
flag, throws the exception if there exists any async tasks left.Fix in this PR is resolve this conflict:
TransportExplainAction.
TermsQueryBuilder
Related Issues
Resolves #1126
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.