Skip to content

Update bundled JDK to JDK-24 #18085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

reta
Copy link
Contributor

@reta reta commented Apr 25, 2025

Description

Update bundled JDK to JDK-24

Blockers so far:

Related Issues

Closes #17661

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for 5d1adf4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 5d1adf4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 41381d0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented May 4, 2025

❌ Gradle check result for b726fe9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta reta force-pushed the update.jdk.24 branch from b726fe9 to ef5563b Compare May 4, 2025 13:11
Copy link
Contributor

github-actions bot commented May 4, 2025

❌ Gradle check result for ef5563b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented May 4, 2025

❌ Gradle check result for ef5563b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented May 4, 2025

❌ Gradle check result for ef5563b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented May 4, 2025

✅ Gradle check result for ef5563b: SUCCESS

Copy link

codecov bot commented May 4, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 72.47%. Comparing base (631bed4) to head (d7dbd16).

Files with missing lines Patch % Lines
...g/opensearch/repositories/hdfs/HdfsRepository.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #18085      +/-   ##
============================================
- Coverage     72.53%   72.47%   -0.06%     
+ Complexity    67396    67327      -69     
============================================
  Files          5492     5492              
  Lines        311127   311113      -14     
  Branches      45224    45225       +1     
============================================
- Hits         225680   225485     -195     
- Misses        67063    67254     +191     
+ Partials      18384    18374      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

github-actions bot commented May 9, 2025

❌ Gradle check result for a8530b8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta reta force-pushed the update.jdk.24 branch from a8530b8 to aaeb772 Compare May 11, 2025 22:16
Copy link
Contributor

❌ Gradle check result for aaeb772: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for a1ee1e7: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta reta force-pushed the update.jdk.24 branch from a1ee1e7 to 72d7304 Compare May 16, 2025 15:44
Copy link
Contributor

✅ Gradle check result for 72d7304: SUCCESS

@rishabh6788
Copy link
Contributor

@reta Do you think it will be a good idea to run some benchmarks on this PR to gauge any performance gains or regressions before we merge it?

Signed-off-by: Andriy Redko <[email protected]>
@reta reta force-pushed the update.jdk.24 branch from 72d7304 to d7dbd16 Compare May 21, 2025 00:04
@reta
Copy link
Contributor Author

reta commented May 21, 2025

@reta Do you think it will be a good idea to run some benchmarks on this PR to gauge any performance gains or regressions before we merge it?

Thanks @rishabh6788 , definitely yes, but the HDFS (basically, Hadoop) is a hard showstopper here, looking for the options to approach that. Thank you.

Copy link
Contributor

✅ Gradle check result for d7dbd16: SUCCESS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Libraries & Interfaces enhancement Enhancement or improvement to existing feature or request skip-changelog v3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add JDK-24 support
4 participants