fix: support {{period_start}} placeholder in Alert Insight#1341
Open
DdangJin wants to merge 1 commit intoopensearch-project:mainfrom
Open
fix: support {{period_start}} placeholder in Alert Insight#1341DdangJin wants to merge 1 commit intoopensearch-project:mainfrom
DdangJin wants to merge 1 commit intoopensearch-project:mainfrom
Conversation
DdangJin
requested review from
AWSHurneyt,
amsiglan,
bowenlan-amzn,
eirsep,
getsaurabh02,
lezzago,
praveensameneni,
rishabhmaurya,
riysaxen-amzn and
sbcd90
as code owners
DdangJin
force-pushed
the
fix/alert-insight/period-start
branch
from
016fd41 to
db7bbca
Compare
Signed-off-by: DdangJin <hdj997@gmail.com>
DdangJin
force-pushed
the
fix/alert-insight/period-start
branch
from
db7bbca to
5eaecdc
Compare
DdangJin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed an issue where Alert Insight failed to parse queries containing
{{period_start}}.The code has been updated to correctly calculate the start time (based on the notification time) and replace the
{{period_start}}placeholder with the actual timestamp before executing the search.This resolves the
failed to parse date fieldexception when using time ranges in extraction queries.Issues Resolved
Fixes #1340
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.