Read max triggers limit from backend setting#1387
Open
manaswini1920 wants to merge 1 commit intoopensearch-project:mainfrom
Open
Read max triggers limit from backend setting#1387manaswini1920 wants to merge 1 commit intoopensearch-project:mainfrom
manaswini1920 wants to merge 1 commit intoopensearch-project:mainfrom
Conversation
manaswini1920
requested review from
AWSHurneyt,
amsiglan,
bowenlan-amzn,
eirsep,
getsaurabh02,
lezzago,
praveensameneni,
rishabhmaurya,
riysaxen-amzn and
sbcd90
as code owners
Collaborator
|
@manaswini1920 Could you remove this environment variable from the cypress workflow? And adjust this line to just |
manaswini1920
force-pushed
the
fix/configurable-max-triggers
branch
from
87180bd to
928d125
Compare
manaswini1920
force-pushed
the
fix/configurable-max-triggers
branch
from
928d125 to
c765586
Compare
Fetch plugins.alerting.monitor.max_triggers cluster setting instead of using hardcoded MAX_TRIGGERS constant. Falls back to default of 10 if the setting cannot be retrieved. Signed-off-by: Manaswini Ragamouni <ragamanu@amazon.com> Resolves opensearch-project/alerting#468 Signed-off-by: Manaswini Ragamouni <ragamanu@amazon.com>
manaswini1920
force-pushed
the
fix/configurable-max-triggers
branch
from
c765586 to
8f4be5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fetch plugins.alerting.monitor.max_triggers cluster setting instead of using hardcoded MAX_TRIGGERS constant. Falls back to default of 10 if the setting cannot be retrieved.
Resolves opensearch-project/alerting#468
Issues Resolved
opensearch-project/alerting#1828
https://github.com/opensearch-project/alerting#468
Testing info here : opensearch-project/common-utils#913 (comment)
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.