Use SdkClient for persistence in GetAlerts, DeleteComment, GetWorkflo…#2061
Merged
eirsep merged 1 commit intoopensearch-project:remote-metadata-supportfrom Apr 1, 2026
Conversation
manaswini1920
requested review from
AWSHurneyt,
amsiglan,
bowenlan-amzn,
eirsep,
engechas,
getsaurabh02,
goyamegh,
jowg-amazon,
lezzago,
praveensameneni,
rishabhmaurya,
riysaxen-amzn,
sbcd90 and
toepkerd
as code owners
…wAlerts, ExecuteMonitor Replace direct client calls with sdkClient equivalents: - TransportGetAlertsAction: sdkClient.getDataObject() + searchDataObjectAsync() - TransportDeleteAlertingCommentAction: sdkClient.deleteDataObject() + searchDataObject() - TransportGetWorkflowAlertsAction: sdkClient.searchDataObject() x2 - TransportExecuteMonitorAction: sdkClient.getDataObjectAsync() Signed-off-by: Manaswini Ragamouni <ragamanu@amazon.com>
manaswini1920
force-pushed
the
feature/sdk-persistence-batch3
branch
from
414cf51 to
0e2d0ef
Compare
engechas
approved these changes
Mar 30, 2026
eirsep
approved these changes
Apr 1, 2026
Member
eirsep
left a comment
eirsep
left a comment
There was a problem hiding this comment.
we need to make client changes in query and bucket level monitor and ppl monitor.
we also need changes in alert history metadata cleanup jobs.
eirsep
merged commit b7dcd09
into
opensearch-project:remote-metadata-support
18 checks passed
eirsep
reviewed
Apr 1, 2026
|
|
||
| override fun onFailure(t: Exception) { | ||
| actionListener.onFailure(AlertingException.wrap(t)) | ||
| if (!getResponse.isSourceEmpty) { |
Member
There was a problem hiding this comment.
plz add else block. this will cause a listener leak and thread will hang forever causing node drops.
Member
There was a problem hiding this comment.
if (!getResponse.isSourceEmpty) {
// ... existing parse + executeMonitor logic
} else {
actionListener.onFailure(
AlertingException.wrap(
OpenSearchStatusException("Monitor source is empty for id: ${execMonitorRequest.monitorId}", RestStatus.NOT_FOUND)
)
)
}
This was referenced Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use SdkClient for persistence in 4 more transport actions:
Related Issues
Follows pattern from #2053, #2060
Check List
--signoff.