fixed search_pipeline for request body#1091
Open
ThyTran1402 wants to merge 2 commits intoopensearch-project:mainfrom
Open
fixed search_pipeline for request body#1091ThyTran1402 wants to merge 2 commits intoopensearch-project:mainfrom
ThyTran1402 wants to merge 2 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Thy Tran <58045538+ThyTran1402@users.noreply.github.com>
ThyTran1402
requested review from
Tokesh,
VachaShah,
Xtansia,
aabeshov,
harshavamsi,
karenyrx,
lucy66hw and
sachetalva
as code owners
Signed-off-by: Thy Tran <58045538+ThyTran1402@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Root cause: search_pipeline in
SearchRequestBodyis typed as type: string (pipeline name only), but OpenSearch also supports passing an inline pipeline definition as object form directly in the request body.Fixed:
Added a new
SearchPipelineRefunion type that accepts either:SearchPipelineStructureobject: an inline pipeline definition withrequest_processors,response_processors,and/orphase_results_processorsRelated PR: #1011
Issues Resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.