Change the logic of RCA conditional execution tag system#423
Open
Tjofil wants to merge 3 commits intoopensearch-project:mainfrom
Open
Change the logic of RCA conditional execution tag system#423Tjofil wants to merge 3 commits intoopensearch-project:mainfrom
Tjofil wants to merge 3 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com>
Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com>
Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com>
Tjofil
requested review from
ansjcy,
getsaurabh02,
goyamegh,
khushbr,
praveensameneni,
sbcd90 and
sgup432
as code owners
Codecov Report
@@ Coverage Diff @@
## main #423 +/- ##
============================================
- Coverage 75.98% 75.93% -0.06%
- Complexity 2581 2584 +3
============================================
Files 302 302
Lines 15356 15372 +16
Branches 1213 1215 +2
============================================
+ Hits 11669 11672 +3
- Misses 3193 3203 +10
- Partials 494 497 +3
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#308
Changed the locus tag system to support multiple values in the config files. Now when having a non dedicated cluster manager node, including that info inside the .conf file will allow for execution of RCA nodes with only cluster manager OR data node tags. Also with a dedicated cluster manager node, only the cluster manager tagged RCA nodes will be executed.
Changed this for HotShardRCA for now, should switch for all other analyses at some point.
Additional context
Add any other context or screenshots about the feature request here.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.