Add validate url check while reading thread intel feed (#1660)#1668
Open
nishtham-amazon wants to merge 1 commit intoopensearch-project:2.18from
Open
Add validate url check while reading thread intel feed (#1660)#1668nishtham-amazon wants to merge 1 commit intoopensearch-project:2.18from
nishtham-amazon wants to merge 1 commit intoopensearch-project:2.18from
Conversation
…oject#1660) * Add validate url check while reading thread intel feed Signed-off-by: nishtham <nishtham@amazon.com> * Added unit tests for url validation for threat intel feeds --------- Signed-off-by: nishtham <nishtham@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add URL validation to threat intel URL_DOWNLOAD source type to prevent SSRF and local file read vulnerabilities.
The ThreatIntelFeedParser.getThreatIntelFeedReaderCSV() methods pass user-supplied URLs directly to url.openConnection() inside AccessController.doPrivileged() without any validation. This allows users with the
security_analytics_full_access role to:
This change adds a validateUrl() method in ThreatIntelFeedParser that enforces:
Validation is applied in three locations:
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/security-analytics/blob/main/CONTRIBUTING.md#developer-
certificate-of-origin).