Refactor client.OpenSergoClient with new model and refine code #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Zhao <[email protected]>
Signed-off-by: Eric Zhao <[email protected]>
…or handling Signed-off-by: Eric Zhao <[email protected]>
jnan806
approved these changes
Dec 1, 2022
jnan806
requested changes
Dec 1, 2022
Signed-off-by: Eric Zhao <[email protected]>
Signed-off-by: Eric Zhao <[email protected]>
sczyh30
force-pushed
the
option-style-refactor
branch
from
685f6ed to
ff3f26f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Refactor client.OpenSergoClient with new model and refine code.
A sample of usage:
Does this pull request fix one issue?
Resolves #14, #15
Describe how you did it
SubscribeKeytomodelpkg and refineSubscriberRegistryapi.OpenSergoClientinterface and functional SubscribeOptionsDescribe how to verify it
Test cases TBD...
Special notes for reviews
NOTE: this PR contains breaking changes of API.