Migrate to skillsaw 0.15.0 - #599
Conversation
Bump the skillsaw Action pin, review Action pin, container image, and config version to 0.15.0. The config version bump activates the new agentskill-unreferenced-files rule (dead-file detection), which flagged 11 tracked files; each was investigated and resolved: - payload-autodl-json, payload-results-yaml: reference scripts/validate.py from SKILL.md — agents can now find the canonical schema validators. - prow-job-analyze-resource: link SCRIPTS.md (detailed script docs) from SKILL.md; delete create_inline_html_files.py, dead legacy superseded by create_context_html_files.py (nothing references it). - jira/status-analysis: document summarize_issue.py, triage_issues.py, and validate_feature_updates.py in the skill's module table — all three are used by the update-weekly-status / generate-feature-updates commands. - must-gather-analyzer: add missing OVN database and Windows node log analysis sections for analyze_ovn_dbs.py and analyze_windows_logs.py. - k8s-ocp-olm-expert: reference the bundled config-template.json and config-example.json from the configuration setup instructions. Also exclude **/__pycache__/** so local build artifacts don't trip strict lints for contributors. skillsaw 0.15.0 lint: 44 rules, 0 errors, 0 warnings, grade A. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: not-stbenjam The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
needs-ok-to-test
|
Hi @not-stbenjam. Thanks for your PR. I'm waiting for a openshift-eng member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThis PR updates Skillsaw references to 0.15.0, adds a ChangesSkillsaw and skill documentation
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 10✅ Passed checks (10 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/ok-to-test |
openshift-ci
Bot
added
ok-to-test
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@plugins/jira/skills/status-analysis/SKILL.md`:
- Around line 105-107: The status-analysis SKILL.md intro still કહે the skill
has four sub-modules, but the table now lists more entries. Update the opening
sentence in this document to match the expanded count and keep it consistent
with the sub-module list, using the surrounding section that describes the
skill’s components as the place to adjust the wording.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 0ced5440-e593-4312-9a0e-1c60b3c7be73
📒 Files selected for processing (11)
.github/workflows/lint-plugins.yml.github/workflows/lint-review.yml.skillsaw.yamlMakefileplugins/ci/skills/payload-autodl-json/SKILL.mdplugins/ci/skills/payload-results-yaml/SKILL.mdplugins/ci/skills/prow-job-analyze-resource/SKILL.mdplugins/ci/skills/prow-job-analyze-resource/create_inline_html_files.pyplugins/jira/skills/status-analysis/SKILL.mdplugins/must-gather/skills/must-gather-analyzer/SKILL.mdplugins/olm-team/skills/k8s-ocp-olm-expert/SKILL.md
💤 Files with no reviewable changes (1)
- plugins/ci/skills/prow-job-analyze-resource/create_inline_html_files.py
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
/ok-to-test |
The skillsaw 0.15.0 action defaults no-custom-rules to true, which skips the custom rules in .skillsaw/. Set it to false so CI continues to enforce them. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
openshift-ci
Bot
added
the
needs-rebase
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
2 participants
Summary
Migrates skillsaw from 0.14.1 to 0.15.0 — Action pins (lint + review), container image, and
.skillsaw.yamlconfig version.The config version bump activates the new agentskill-unreferenced-files rule (dead-file detection in skills). It flagged 11 tracked files; each was investigated individually:
scripts/validate.py×2SCRIPTS.mdcreate_inline_html_files.pycreate_context_html_files.py(whichgenerate_html_report.pyinvokes); nothing references itsummarize_issue.py,triage_issues.py,validate_feature_updates.pyupdate-weekly-status/generate-feature-updatescommandsanalyze_ovn_dbs.py,analyze_windows_logs.pyconfig-template.json,config-example.jsonAlso excludes
**/__pycache__/**so local build artifacts don't trip strict lints for contributors.Verification
skillsaw lint@ 0.15.0: 44 rules run, 0 errors, 0 warnings, grade A, exit 0 (strict mode).🤖 Generated with Claude Code
Summary by CodeRabbit
0.15.0, including CI workflow action pin updates and rule settings.ciplugin version to0.0.56in marketplace metadata and the site index; added__pycache__exclusions.