ci:analyze-disruption: find matching Jira cards - #669
Conversation
After analyzing disruption, the skill now automatically searches TRT and OCPBUGS for existing cards labeled "disruption" (plus a broader search for unlabeled cards). Results appear in a new "Known Disruption Issues" report section. If no match is found, offers interactive bug filing via jira:create with the "disruption" label. Adds --skip-jira escape hatch. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Closed cards may have been closed prematurely or document prior investigations that provide context for recurring disruption patterns. Results are grouped into Open and Previously Resolved sections. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe CI disruption analysis skill now searches Jira for known issues, reports results, supports issue labeling and creation, and handles unavailable Jira tools. The CI plugin version increases to ChangesCI disruption analysis
Plugin metadata
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant AnalyzeDisruptionSkill
participant TRT
participant OCPBUGS
participant AnalysisReport
AnalyzeDisruptionSkill->>TRT: Search disruption cards
AnalyzeDisruptionSkill->>OCPBUGS: Search disruption bugs
TRT-->>AnalyzeDisruptionSkill: Return matching issues
OCPBUGS-->>AnalyzeDisruptionSkill: Return matching issues
AnalyzeDisruptionSkill->>AnalysisReport: Add known issues
AnalyzeDisruptionSkill->>OCPBUGS: Label or create issue
OCPBUGS-->>AnalysisReport: Update report
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 9 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (9 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (1)
plugins/ci/skills/analyze-disruption/SKILL.md (1)
525-529: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winCoordinate with pull request
#655before mergeOverlap is MODERATE (60–84%). Pull request
#655is the only same-file candidate. Both changes add existing-disruption or bug discovery, but#655uses component-scoped lookup while#669uses backend-name JQL lookup and interactive filing. Consolidate the shared guidance or define the step boundary. Other candidates are LOW because they change different files.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@plugins/ci/skills/analyze-disruption/SKILL.md` around lines 525 - 529, Update the “Known Disruption Issue Lookup” guidance to coordinate with pull request `#655` by clearly defining the boundary between component-scoped lookup and backend-name JQL lookup, or consolidating their shared existing-disruption and bug-discovery guidance. Preserve the --skip-jira behavior and interactive filing flow for this step.Sources: Coding guidelines, Learnings
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@plugins/ci/skills/analyze-disruption/SKILL.md`:
- Around line 541-543: Update the four fenced code blocks in the disruption
analysis documentation, including the JQL and prompt examples near the
referenced sections, to declare an appropriate language identifier such as text
or jql. Keep each block’s content unchanged while resolving the markdownlint
MD040 warnings.
- Around line 30-32: Update Step 1 to parse and retain --skip-jira as a boolean
option alongside --backends, then update the Step 10 Jira-search condition to
bypass the lookup when this flag is set while preserving the existing search
behavior otherwise.
- Around line 536-549: Update the Jira search flow around the two queries using
searchJiraIssuesUsingJql so open and closed issues are collected independently
instead of relying on one mixed-status maxResults: 10 page. Add appropriate
status filters to separate active and resolved results, or paginate via
nextPageToken until both groups are gathered, then deduplicate while preserving
matches for the Previously Resolved section.
- Around line 551-552: Update the Jira query guidance to request the resolution
field and explicitly map it into the closed-card results’ Resolution column;
otherwise rename that column to Status. Preserve the existing query limits,
other fields, and deduplication behavior.
---
Nitpick comments:
In `@plugins/ci/skills/analyze-disruption/SKILL.md`:
- Around line 525-529: Update the “Known Disruption Issue Lookup” guidance to
coordinate with pull request `#655` by clearly defining the boundary between
component-scoped lookup and backend-name JQL lookup, or consolidating their
shared existing-disruption and bug-discovery guidance. Preserve the --skip-jira
behavior and interactive filing flow for this step.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: c65363d8-97b6-4fda-87c5-a75097b8f2e5
📒 Files selected for processing (3)
.claude-plugin/marketplace.jsonplugins/ci/.claude-plugin/plugin.jsonplugins/ci/skills/analyze-disruption/SKILL.md
- Add language identifiers to fenced code blocks (jql, text, markdown) - Parse --skip-jira flag in Step 1 alongside --backends - Split into 4 separate queries (open/closed x labeled/broad) so maxResults doesn't let one category crowd out the other - Add resolution field to query results and table example Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neisw, smg247 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
disruption(high confidence) and a broader text search to catch unlabeled cardsdisruptionlabel via thejira:createskill--skip-jiraescape hatch to opt out of the searchDetails
Adds a new Step 10: Known Disruption Issue Lookup to the analyze-disruption skill with three sub-steps:
labels = "disruption", one broadertext ~ "disruption {backend}". Results grouped into Open and Previously Resolved sections.disruptionlabel.Gracefully degrades when Jira MCP is unavailable.
Summary by CodeRabbit
New Features
--skip-jiraflag for disruption analysis.Chores