ART-19650: Fix group input to use client-side filtering - #208
Conversation
- Add wildcard '*' support for group filtering (matches all groups) - Dispatch change events when autocomplete selections are made - This ensures the "Filter view" button appears when group/assembly/source_repo fields are changed via autocomplete - Previously, selecting from autocomplete dropdowns would update the input value but not trigger form change detection - Add comprehensive tests for group filtering behavior Fixes: ART-19650 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> rh-pre-commit.version: 2.4.0 rh-pre-commit.check-secrets: ENABLED
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@locriandev: This pull request references ART-19650 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
Summary
Enables client-side filtering by group for already-cached results, avoiding unnecessary BigQuery queries.
The Problem
Currently, group filtering works but always requires fetching from BigQuery. This fix enables filtering cached results client-side.
Current Behavior (Before Fix)
New Behavior (After Fix)
Root Cause
The group field was already supported in the
matchesFilters()client-side filtering function, but the UI wasn't making it discoverable because:changeevent*to match all groups (unlike assembly field)Solution
Client-side filtering enhancements
*support for group field (consistent with assembly field)changeevents when selections are made:setupAutocomplete()- used for Group fieldsetupStaticAutocomplete()- used for Assembly fieldsetupSourceRepoAutocomplete()- used for Source Repository fieldFiles Changed
static/js/index.js: Enhanced group filtering + event dispatching in 3 autocomplete functionstests/static/index.test.js: Added 3 new tests for group filtering behaviorapp.py: Auto-formatting by ruffBenefits
Testing
How to Test
Fixes: https://redhat.atlassian.net/browse/ART-19650