Bump fast-xml-parser and @aws-sdk/client-secrets-manager in /art-cluster/cloudflare - #3174
Conversation
Removes [fast-xml-parser](https://github.com/NaturalIntelligence/fast-xml-parser). It's no longer used after updating ancestor dependency [@aws-sdk/client-secrets-manager](https://github.com/aws/aws-sdk-js-v3/tree/HEAD/clients/client-secrets-manager). These dependencies need to be updated together. Removes `fast-xml-parser` Updates `@aws-sdk/client-secrets-manager` from 3.670.0 to 3.1088.0 - [Release notes](https://github.com/aws/aws-sdk-js-v3/releases) - [Changelog](https://github.com/aws/aws-sdk-js-v3/blob/main/clients/client-secrets-manager/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js-v3/commits/v3.1088.0/clients/client-secrets-manager) --- updated-dependencies: - dependency-name: fast-xml-parser dependency-version: dependency-type: indirect - dependency-name: "@aws-sdk/client-secrets-manager" dependency-version: 3.1088.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @dependabot[bot]. Thanks for your PR. I'm waiting for a openshift-eng member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-ci
Bot
added
the
needs-ok-to-test
WalkthroughThe Cloudflare package updates ChangesCloudflare dependency update
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 11✅ Passed checks (11 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@art-cluster/cloudflare/package.json`:
- Line 17: Update the "`@aws-sdk/client-secrets-manager`" dependency entry in
package.json to pin version 3.1088.0 exactly, removing the caret range while
preserving the lockfile-aligned version.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift-eng/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: fe375a49-f158-4b92-a15b-848cbe026fa7
⛔ Files ignored due to path filters (1)
art-cluster/cloudflare/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
art-cluster/cloudflare/package.json
| }, | ||
| "dependencies": { | ||
| "@aws-sdk/client-secrets-manager": "^3.670.0", | ||
| "@aws-sdk/client-secrets-manager": "^3.1088.0", |
There was a problem hiding this comment.
🔒 Security & Privacy | 🟠 Major | ⚡ Quick win
Pin the production dependency exactly.
The caret allows future AWS SDK versions to be selected outside this reviewed change. Since the lockfile already resolves 3.1088.0, use an exact manifest pin as required by the supply-chain instructions.
Proposed fix
- "`@aws-sdk/client-secrets-manager`": "^3.1088.0",
+ "`@aws-sdk/client-secrets-manager`": "3.1088.0",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "@aws-sdk/client-secrets-manager": "^3.1088.0", | |
| "`@aws-sdk/client-secrets-manager`": "3.1088.0", |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@art-cluster/cloudflare/package.json` at line 17, Update the
"`@aws-sdk/client-secrets-manager`" dependency entry in package.json to pin
version 3.1088.0 exactly, removing the caret range while preserving the
lockfile-aligned version.
Source: Path instructions
Removes fast-xml-parser. It's no longer used after updating ancestor dependency @aws-sdk/client-secrets-manager. These dependencies need to be updated together.
Removes
fast-xml-parserUpdates
@aws-sdk/client-secrets-managerfrom 3.670.0 to 3.1088.0Release notes
Sourced from @aws-sdk/client-secrets-manager's releases.
... (truncated)
Changelog
Sourced from @aws-sdk/client-secrets-manager's changelog.
... (truncated)
Commits
73de389Publish v3.1088.0d43e5bfchore(codegen): sync to use typesVersions entries for submodules (#8195)ec24bb4Publish v3.1087.0a20c28dchore(codegen): sync for codegen and include OAuthIAM operation for signin li...64c3e50Publish v3.1086.08d0b498Publish v3.1085.0c34ce8aPublish v3.1084.0ceb9aeePublish v3.1083.09d72bc2chore(core/client): remove TypeScript version user-agent metric (#8177)afc3740Publish v3.1082.0Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.
Summary by CodeRabbit