Skip to content

Revert "Skip oc-mirror binary sync for OCP 5.0+" - #3211

Draft
dorzel wants to merge 1 commit into
openshift-eng:mainfrom
dorzel:main
Draft

Revert "Skip oc-mirror binary sync for OCP 5.0+"#3211
dorzel wants to merge 1 commit into
openshift-eng:mainfrom
dorzel:main

Conversation

@dorzel

@dorzel dorzel commented Jul 28, 2026

Copy link
Copy Markdown

Summary by CodeRabbit

  • Bug Fixes
    • Updated release publishing so oc-mirror is correctly extracted and bundled for 5.x and later releases.
    • Preserved the existing behavior of excluding oc-mirror from releases in the 4.9 and earlier series.
    • This ensures newer release payloads include the tooling needed for mirroring workflows.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 28, 2026
@openshift-ci

openshift-ci Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci

openshift-ci Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign thegreyd for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift-eng/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: e1371f69-f639-4a6e-9687-a438e2f50bab

📥 Commits

Reviewing files that changed from the base of the PR and between fbfc753 and fe4fae0.

📒 Files selected for processing (1)
  • pyartcd/pyartcd/pipelines/promote.py

Walkthrough

The publish_client pipeline now extracts oc-mirror for group versions 4.14 and later on all architectures, and for versions 4.10–4.13 on x86_64; versions through 4.9 remain excluded.

Changes

oc-mirror extraction

Layer / File(s) Summary
Update extraction version and architecture gating
pyartcd/pyartcd/pipelines/promote.py
The extraction condition removes the major < 5 restriction and applies the updated version and architecture thresholds.

Estimated code review effort: 2 (Simple) | ~5 minutes

Suggested reviewers: joepvd, ashwindasr, thegreyd

🚥 Pre-merge checks | ✅ 11
✅ Passed checks (11 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: reverting the oc-mirror sync skip for OCP 5.0+.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
No-Weak-Crypto ✅ Passed The PR only changes oc-mirror extraction gating in publish_client; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons appear in the changed code.
Container-Privileges ✅ Passed PR only changes promote.py logic; no container/K8s manifests were modified and no privileged/root settings were added.
No-Sensitive-Data-In-Logs ✅ Passed Diff only removes a major-version guard on oc-mirror extraction; no logging changes or new sensitive fields were added.
No-Hardcoded-Secrets ✅ Passed Changed lines only adjust oc-mirror version gating; no hardcoded secrets, credential literals, or secret-pattern matches were introduced.
No-Injection-Vectors ✅ Passed The PR only relaxes the oc-mirror version check; it adds no SQL/shell/eval/yaml/pickle/innerHTML sinks or user-input execution paths.
Ai-Attribution ✅ Passed HEAD commit is a plain revert with no AI-tool mentions and no Assisted-by/Generated-by trailers.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant