Skip to content

CI Doctors: use correct file for configuring plugin hooks - #254

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift-eng:mainfrom
pmtk:ci-doctor-fix-hooks
Aug 3, 2026
Merged

CI Doctors: use correct file for configuring plugin hooks#254
openshift-merge-bot[bot] merged 1 commit into
openshift-eng:mainfrom
pmtk:ci-doctor-fix-hooks

Conversation

@pmtk

@pmtk pmtk commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features

    • Added validation for MicroShift CI RCA output when analysis completes.
    • Improved plugin hook path handling for reliable RCA validation.
  • Chores

    • Updated the lvms-ci plugin to version 1.3.2.
    • Updated the microshift-ci plugin to version 1.5.4.

@openshift-ci

openshift-ci Bot commented Aug 3, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2026
@pmtk
pmtk force-pushed the ci-doctor-fix-hooks branch from 0fc1c13 to e1a2dd8 Compare August 3, 2026 13:53
@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

The PR updates LVMS and MicroShift CI plugin versions. It adjusts the LVMS RCA validation path and adds a timed MicroShift SubagentStop validation hook.

Changes

CI plugin updates

Layer / File(s) Summary
Plugin version metadata
.claude-plugin/marketplace.json, plugins/lvms-ci/.claude-plugin/plugin.json, plugins/microshift-ci/.claude-plugin/plugin.json
The LVMS version changes to 1.3.2. The MicroShift version changes to 1.5.4.
RCA validation hooks
plugins/lvms-ci/hooks/hooks.json, plugins/microshift-ci/hooks/hooks.json, plugins/microshift-ci/.claude/settings.json
The LVMS command braces CLAUDE_PLUGIN_ROOT. MicroShift adds the Prow analyzer SubagentStop validation hook and removes the previous settings-based hook configuration.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: kasturinarra, ggiguash

🚥 Pre-merge checks | ✅ 11
✅ Passed checks (11 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
No-Weak-Crypto ✅ Passed The PR changes only plugin metadata and hook configuration; patch and changed-file scans found no weak crypto, custom crypto, or secret-comparison code.
Container-Privileges ✅ Passed The PR changes only plugin versions and hook JSON paths. No changed file or added line contains privileged, host namespace, SYS_ADMIN, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs ✅ Passed The diff adds only generic hook commands, status text, and version values; scans found no logging statements or sensitive-data literals.
No-Hardcoded-Secrets ✅ Passed The PR adds only version values and hook configuration; scans found no API keys, tokens, passwords, private keys, credential URLs, or base64 strings over 32 characters.
No-Injection-Vectors ✅ Passed The added hook commands use quoted CLAUDE_PLUGIN_ROOT paths, and no changed lines contain SQL concatenation, shell=True, eval/exec, pickle.loads, yaml.load, os.system, or dangerouslySetInnerHTML.
Ai-Attribution ✅ Passed The PR contains one commit with no AI-tool mention and no attribution trailers, so no Assisted-by or Generated-by trailer is required and no AI Co-Authored-By trailer is present.
Title check ✅ Passed The title clearly describes the main change: correcting the file used to configure plugin hooks.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label Aug 3, 2026
@ggiguash

ggiguash commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit bff4144 into openshift-eng:main Aug 3, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants