Skip to content

Update github.com/golangci/rowserrcheck digest to d2031e3 - #14

Closed
red-hat-konflux-kflux-prd-rh02[bot] wants to merge 1 commit into
mainfrom
konflux/mintmaker/main/github.com-golangci-rowserrcheck-digest
Closed

Update github.com/golangci/rowserrcheck digest to d2031e3#14
red-hat-konflux-kflux-prd-rh02[bot] wants to merge 1 commit into
mainfrom
konflux/mintmaker/main/github.com-golangci-rowserrcheck-digest

Conversation

@red-hat-konflux-kflux-prd-rh02

@red-hat-konflux-kflux-prd-rh02 red-hat-konflux-kflux-prd-rh02 Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Type Update Change
github.com/golangci/rowserrcheck indirect digest c5f79b8d2031e3

Warning

Some dependencies could not be looked up. Check the warning logs for more information.


Configuration

📅 Schedule: (UTC)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

To execute skipped test pipelines write comment /ok-to-test.


Documentation

Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.

Signed-off-by: red-hat-konflux-kflux-prd-rh02 <190377777+red-hat-konflux-kflux-prd-rh02[bot]@users.noreply.github.com>
@red-hat-konflux-kflux-prd-rh02

Copy link
Copy Markdown
Contributor Author

ℹ️ Artifact update notice

File name: tools/go.mod

In order to perform the update(s) described in the table above, Renovate ran the go get command, which resulted in the following additional change(s):

  • 4 additional dependencies were updated

Details:

Package Change
golang.org/x/mod v0.35.0 -> v0.38.0
golang.org/x/sync v0.20.0 -> v0.22.0
golang.org/x/sys v0.43.0 -> v0.47.0
golang.org/x/tools v0.44.0 -> v0.48.0

@openshift-ci

openshift-ci Bot commented Aug 26, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ruclo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Aug 26, 2026

Copy link
Copy Markdown

Hi @red-hat-konflux-kflux-prd-rh02[bot]. Thanks for your PR.

I'm waiting for a openshift-hyperfleet member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 13745d18-5ea3-4c04-a09e-0ebb5e9c763e

📥 Commits

Reviewing files that changed from the base of the PR and between bca2f92 and be690cb.

⛔ Files ignored due to path filters (1)
  • tools/go.sum is excluded by !**/*.sum, !**/go.sum
📒 Files selected for processing (1)
  • tools/go.mod
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • openshift-hyperfleet/architecture (manual)
  • openshift-hyperfleet/hyperfleet-api (manual)
  • openshift-hyperfleet/hyperfleet-sentinel (manual)
  • openshift-hyperfleet/hyperfleet-adapter (manual)
  • openshift-hyperfleet/hyperfleet-broker (manual)

Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review.


📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated supporting tool components to newer versions.
    • Improved compatibility and reliability of development and validation workflows.

Walkthrough

Updated indirect dependency versions in tools/go.mod. The changes update github.com/golangci/rowserrcheck, golang.org/x/mod, golang.org/x/sync, golang.org/x/sys, and golang.org/x/tools. The golang.org/x/text version remains unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to be690

This is a localized dependency digest update with no actionable merge-blocking risk remaining after normal checks and review.

Suggested reviewers: pnguyen44, aredenba-rh, kuudori

🚥 Pre-merge checks | ✅ 11
✅ Passed checks (11 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Sec-02: Secrets In Log Output ✅ Passed PASS. The PR changes only tools/go.mod and tools/go.sum. Added lines contain dependency versions and checksums only. No slog, log, logr, zap, or fmt.Print* statement changed or added. No token, passwo…
No Hardcoded Secrets ✅ Passed No hardcoded secret was introduced. The diff changes only indirect Go module versions in tools/go.mod and Go checksum metadata in tools/go.sum. The added go.sum base64-like values are Go integrity has…
No Weak Cryptography ✅ Passed PASS. The pull request changes only tools/go.mod and tools/go.sum. The diff updates indirect tool and golang.org/x/* dependency versions and checksums. It adds no Go source, cryptographic import…
No Injection Vectors ✅ Passed PASS: The PR changes only tools/go.mod and tools/go.sum. The diff contains dependency version and checksum updates, with no added Go, SQL, template, or YAML code. No changed code introduces SQL concat…
No Privileged Containers ✅ Passed PASS — The pull request changes only tools/go.mod and tools/go.sum. The diff updates Go dependency versions and checksums. It adds no Kubernetes/OpenShift manifest, Helm template, or Dockerfile, a…
No Pii Or Sensitive Data In Logs ✅ Passed PASS. The pull request changes only tools/go.mod and tools/go.sum. The diff contains dependency version and checksum replacements for indirect tooling dependencies. It adds no slog, logr, `zap…
Title check ✅ Passed The title identifies the github.com/golangci/rowserrcheck digest update, which is the stated objective and a documented change in tools/go.mod.
Description check ✅ Passed The description directly documents the github.com/golangci/rowserrcheck digest update and its manual-merge configuration.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Full details: Sec-02: Secrets In Log Output

Explanation

PASS. The PR changes only tools/go.mod and tools/go.sum. Added lines contain dependency versions and checksums only. No slog, log, logr, zap, or fmt.Print* statement changed or added. No token, password, credential, or secret field or interpolation is introduced. CWE-532 is not introduced by this PR.

Full details: No Hardcoded Secrets

Explanation

No hardcoded secret was introduced. The diff changes only indirect Go module versions in tools/go.mod and Go checksum metadata in tools/go.sum. The added go.sum base64-like values are Go integrity hashes, not configuration secrets. No API key, token, password, private key, credential URL, or secret-named string assignment appears. CWE-798 and CVE criteria do not apply.

Full details: No Weak Cryptography

Explanation

PASS. The pull request changes only tools/go.mod and tools/go.sum. The diff updates indirect tool and golang.org/x/* dependency versions and checksums. It adds no Go source, cryptographic import, cipher construction, SHA-1 security use, or secret comparison. Makefile uses the changed module through the pinned golangci-lint tool path only. No CWE-327 or CWE-208 failure condition is introduced.

Full details: No Injection Vectors

Explanation

PASS: The PR changes only tools/go.mod and tools/go.sum. The diff contains dependency version and checksum updates, with no added Go, SQL, template, or YAML code. No changed code introduces SQL concatenation or fmt.Sprintf queries (CWE-89), unvalidated exec.Command/exec.CommandContext input (CWE-78), template.HTML wrapping (CWE-79), or unsafe yaml.Unmarshal input (CWE-502).

Full details: No Privileged Containers

Explanation

PASS — The pull request changes only tools/go.mod and tools/go.sum. The diff updates Go dependency versions and checksums. It adds no Kubernetes/OpenShift manifest, Helm template, or Dockerfile, and no changed content introduces privileged: true, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation: true, runAsUser: 0, or USER root. No CWE or CVE applies.

Full details: No Pii Or Sensitive Data In Logs

Explanation

PASS. The pull request changes only tools/go.mod and tools/go.sum. The diff contains dependency version and checksum replacements for indirect tooling dependencies. It adds no slog, logr, zap, log, or fmt.Print* logging statement, and it changes no Go, application, or runtime source file. The updated module is used through the tooling module for golangci-lint and setup-envtest, not through the application module. No explicit PII, session ID, raw body, or credential-bearing hostname log exposure is introduced.

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch konflux/mintmaker/main/github.com-golangci-rowserrcheck-digest
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch konflux/mintmaker/main/github.com-golangci-rowserrcheck-digest

Comment @coderabbitai help to get the list of available commands.

@ciaranRoche

Copy link
Copy Markdown
Contributor

Superseded by consolidated dependency PR #26

ma-hill pushed a commit to ma-hill/hyperfleet-applier that referenced this pull request Aug 27, 2026
Consolidates 14 individual Konflux dependency PRs into a single update:

Root module (go.mod):
- k8s.io/api: v0.36.3 → v0.36.4 (openshift-hyperfleet#19)
- k8s.io/apimachinery: v0.36.3 → v0.36.4 (openshift-hyperfleet#19)
- k8s.io/client-go: v0.36.3 → v0.36.4 (openshift-hyperfleet#19)
- k8s.io/apiextensions-apiserver: v0.36.0 → v0.36.4 (openshift-hyperfleet#19)
- k8s.io/kube-openapi: 43fb72c5454a → be32def86098 (openshift-hyperfleet#16)
- k8s.io/utils: b8788abfbbc2 → cf1189d6abe3 (openshift-hyperfleet#17)

Tools module (tools/go.mod):
- charm.land/lipgloss/v2: v2.0.3 → v2.0.6 (openshift-hyperfleet#20)
- codeberg.org/chavacava/garif: v0.2.0 → v0.2.1 (openshift-hyperfleet#21)
- github.com/Abirdcfly/dupword: v0.1.7 → v0.1.8 (openshift-hyperfleet#22)
- github.com/AlwxSin/noinlineerr: v1.0.5 → v1.0.6 (openshift-hyperfleet#23)
- github.com/Antonboom/errname: v1.1.1 → v1.1.2 (openshift-hyperfleet#24)
- github.com/Antonboom/nilnil: v1.1.1 → v1.1.2 (openshift-hyperfleet#25)
- github.com/charmbracelet/ultraviolet: 1948445e3318 → 68fa937c71be (openshift-hyperfleet#12)
- github.com/golangci/gofmt: d62b90e6713d → e84e05053792 (openshift-hyperfleet#13)
- github.com/golangci/rowserrcheck: c5f79b8a11ba → d2031e3af752 (openshift-hyperfleet#14)
- github.com/timakin/bodyclose: 73d1f95b84b4 → 857993a2939c (openshift-hyperfleet#15)
- mvdan.cc/unparam: 5beb8c8f8f15 → 2fa3d841b0c8 (openshift-hyperfleet#18)

Additionally upgrades golangci-lint to v2.13.1 for gofmt compatibility.

Supersedes: openshift-hyperfleet#12, openshift-hyperfleet#13, openshift-hyperfleet#14, openshift-hyperfleet#15, openshift-hyperfleet#16, openshift-hyperfleet#17, openshift-hyperfleet#18, openshift-hyperfleet#19, openshift-hyperfleet#20, openshift-hyperfleet#21, openshift-hyperfleet#22, openshift-hyperfleet#23, openshift-hyperfleet#24, openshift-hyperfleet#25
@red-hat-konflux-kflux-prd-rh02
red-hat-konflux-kflux-prd-rh02 Bot deleted the konflux/mintmaker/main/github.com-golangci-rowserrcheck-digest branch August 27, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant