Add Client to auto-generated CI config #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsimansk
commented
Sep 11, 2024
dsimansk
commented
Sep 11, 2024
dsimansk
commented
Sep 11, 2024
dsimansk
commented
Sep 11, 2024
dsimansk
force-pushed
the
pr/add-client
branch
2 times, most recently
from
a1bad86
to
96283fb
Compare
dsimansk
force-pushed
the
pr/add-client
branch
from
96283fb
to
0d83ac7
Compare
|
OK, so the build test is passing now. The integration tests are running now. IMO the config is ready to be merged once those are done. |
|
As per our call. The PR is ready to be merged now. |
|
A follow-up to cli-artifacts image: #279 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dsimansk, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 0d8b5ae
into
openshift-knative:main
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks, I'm looking at adding client to CI config generation. See my other comment inline.
Generated config PR: openshift/release#56532
Image changes in midstream: openshift-knative/client@8bf4936
/cc @pierDipi @mgencur