mco: update machine config api dependency #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the machine config types were taken from the operator repo but they have since been moved to the openshift/api repo. This PR switches the mco package to use the new repo for the types. Unfortunately, a few other operators depend on the old versions of the types so it remains as an indirect dependency.
klaskosk
requested review from
kononovn,
trewest,
achuzhoy and
cdvultur
as code owners
klaskosk
added a commit
to klaskosk/eco-gotests
that referenced
this pull request
Jan 23, 2025
Depends-on: openshift-kni/eco-goinfra#892 This PR switches all the uses of types from the machine config operator repo to the openshift/api repo, keeping them up to date.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-on: openshift-kni/eco-gotests#380
Previously, the machine config types were taken from the operator repo but they have since been moved to the openshift/api repo. This PR switches the mco package to use the new repo for the types.
Unfortunately, a few other operators depend on the old versions of the types so it remains as an indirect dependency.