fix: allow user to approve when they are both individual approver and group member #861
Conversation
… group member Previously, when a user was listed as both an individual User approver and a member of a Group approver, the function would return early after checking the first matching approver type. This prevented the user from using their other approval identity entirely. For example, if User entry appeared before Group entry in the approvers list, the user could only approve as an individual user and their Group membership was completely ignored. This fix changes IsUserApprovalChanged to check all approver types without early returns, accumulating valid changes. Now users can exercise all their approval permissions regardless of the order in approvers list.
- Replace manual loop-based slice contains logic with slices.Contains - Apply to group membership checks in ifUserExists, IsUserApprovalChanged, CheckOtherUsersForInvalidChanges, and checkIfUserAlreadyDecided - Replace webhookContains helper function with direct slices.Contains usage - Clean up trailing whitespace
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: l-qing The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @l-qing. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
1 participant
Previously, when a user was listed as both an individual User approver and
a member of a Group approver, the function would return early after checking
the first matching approver type. This prevented the user from using their
other approval identity entirely.
For example, if User entry appeared before Group entry in the approvers list,
the user could only approve as an individual user and their Group membership
was completely ignored.
This fix changes IsUserApprovalChanged to check all approver types without
early returns, accumulating valid changes. Now users can exercise all their
approval permissions regardless of the order in approvers list.