fix(cli): respect forceInstallGosmee in bootstrap #2289
Conversation
Summary of ChangesHello @theakshaypant, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a bug in the CLI's bootstrap command where the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
🔍 PR Lint Feedback
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to correctly handle the --force-install-gosmee flag during the bootstrap process. The change to skip OpenShift route detection when this flag is used is a good fix. However, another change appears to remove the helpful interactive prompt that offered to install the gosmee forwarder for users on non-OpenShift platforms. This could be a regression in usability, and I've provided a comment with a suggestion to address it.
|
thanks, can you check cli.md documentationa nd see to update or rephrase the bootstrap function to mention that force-gosmee will always use gosmee even on openshift bypassing openshift route detection |
When --force-install-gosmee flag is set, skip OpenShift route detection and unconditionally install the gosmee forwarder, regardless of the platform. Updated the docs to make this change more clear and explicit. Jira: https://issues.redhat.com/browse/SRVKP-9062 Signed-off-by: Akshay Pant <[email protected]>
theakshaypant
force-pushed
the
SRVKP-9062-fix-force-gosmee-flag-with-openshift
branch
from
e02c1a6 to
c998dea
Compare
Updated the docs to make this change more apparent and explicit in the docs. |
| (which can be useful if you are running [OpenShift Local](https://developers.redhat.com/products/openshift-local/overview) for instance). | ||
| <https://hook.pipelinesascode.com> and set it up on GitHub. | ||
|
|
||
| **Important:** On OpenShift, the bootstrap command automatically detects and uses |
There was a problem hiding this comment.
Usually, I want to make sure we only use "Important" and things like that sporadically where there is a tricky part of the flow.
We usually add those Important tag when updating documentation because it seems important to say at the time of a pull request and in that context, but with multiple pull requests piling up, we end up with a lot of "Important" notes everywhere. I'd rather have a proper paragraph that reads from top to bottom like a user would do.
3 participants
📝 Description of the Change
When --force-install-gosmee flag is set, skip OpenShift route detection and unconditionally install the gosmee forwarder, regardless of the platform.
👨🏻 Linked Jira
https://issues.redhat.com/browse/SRVKP-9062
🔗 Linked GitHub Issue
Fixes #2067
🚀 Type of Change
fix:)feat:)feat!:,fix!:)docs:)chore:)refactor:)enhance:)deps:)🧪 Testing Strategy
🤖 AI Assistance
If you have used AI assistance, please provide the following details:
Which LLM was used?
Extent of AI Assistance:
Important
If the majority of the code in this PR was generated by an AI, please add a
Co-authored-bytrailer to your commit message.For example:
Co-authored-by: Gemini [email protected]
Co-authored-by: ChatGPT [email protected]
Co-authored-by: Claude [email protected]
Co-authored-by: Cursor [email protected]
Co-authored-by: Copilot [email protected]
**💡You can use the script
./hack/add-llm-coauthor.shto automatically addthese co-author trailers to your commits.
✅ Submitter Checklist
fix:,feat:) matches the "Type of Change" I selected above.make testandmake lintlocally to check for and fix anyissues. For an efficient workflow, I have considered installing
pre-commit and running
pre-commit installtoautomate these checks.