Skip to content

Adjust typos#2243

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
sebrandon1:typos
Sep 10, 2025
Merged

Adjust typos#2243
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
sebrandon1:typos

Conversation

@sebrandon1
Copy link
Copy Markdown
Member

@sebrandon1 sebrandon1 commented Mar 19, 2025

Found a easy typo to fix. overriden --> overridden

@openshift-ci openshift-ci Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 19, 2025
@openshift-ci openshift-ci Bot requested review from everettraven and jkyros March 19, 2025 22:13
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 19, 2025

Hello @sebrandon1! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 19, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 19, 2025

Hi @sebrandon1. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

everettraven
everettraven approved these changes Mar 20, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2025
@JoelSpeed
Copy link
Copy Markdown
Contributor

JoelSpeed commented Apr 11, 2025

/approve

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 11, 2025
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2025
@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Aug 14, 2025

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 14, 2025
@JoelSpeed
Copy link
Copy Markdown
Contributor

JoelSpeed commented Sep 5, 2025

@sebrandon1 Are you able to rebase this one please?

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 5, 2025
@openshift-ci openshift-ci Bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 5, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 5, 2025
@openshift-ci openshift-ci Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 5, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 5, 2025
@JoelSpeed
Copy link
Copy Markdown
Contributor

JoelSpeed commented Sep 5, 2025

/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven, JoelSpeed, sebrandon1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [JoelSpeed,everettraven]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2025
@JoelSpeed
Copy link
Copy Markdown
Contributor

JoelSpeed commented Sep 8, 2025

/verified skip

This is a docs only (typo) change, no functionality to check, skipping verification

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Sep 8, 2025

@JoelSpeed: The /verified command must be used with one of the following actions: by, later, remove, or bypass. See https://docs.ci.openshift.org/docs/architecture/jira/#premerge-verification for more information.

Details

In response to this:

/verified skip

This is a docs only (typo) change, no functionality to check, skipping verification

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@JoelSpeed
Copy link
Copy Markdown
Contributor

JoelSpeed commented Sep 8, 2025

/verified bypass

This is a docs only (typo) change, no functionality to check, skipping verification

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 8, 2025
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Sep 8, 2025

@JoelSpeed: The verified label has been added.

Details

In response to this:

/verified bypass

This is a docs only (typo) change, no functionality to check, skipping verification

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@JoelSpeed
Copy link
Copy Markdown
Contributor

JoelSpeed commented Sep 8, 2025

/retest-required

@JoelSpeed
Copy link
Copy Markdown
Contributor

JoelSpeed commented Sep 8, 2025

/ok-to-test
/retest-required

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 8, 2025
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Sep 8, 2025

/retest-required

Remaining retests: 0 against base HEAD 8634aa4 and 2 for PR HEAD 06a725a in total

2 similar comments
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Sep 8, 2025

/retest-required

Remaining retests: 0 against base HEAD 8634aa4 and 2 for PR HEAD 06a725a in total

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Sep 9, 2025

/retest-required

Remaining retests: 0 against base HEAD 8634aa4 and 2 for PR HEAD 06a725a in total

@JoelSpeed
Copy link
Copy Markdown
Contributor

JoelSpeed commented Sep 9, 2025

/override ci/prow/e2e-aws-serial-2of2
/override ci/prow/e2e-aws-serial-techpreview-2of2

Unrelated commatrix failure

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 9, 2025

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws-serial-2of2, ci/prow/e2e-aws-serial-techpreview-2of2

Details

In response to this:

/override ci/prow/e2e-aws-serial-2of2
/override ci/prow/e2e-aws-serial-techpreview-2of2

Unrelated commatrix failure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Sep 9, 2025

/retest-required

Remaining retests: 0 against base HEAD be976da and 1 for PR HEAD 06a725a in total

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Sep 9, 2025

/retest-required

Remaining retests: 0 against base HEAD be976da and 2 for PR HEAD 06a725a in total

5 similar comments
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Sep 9, 2025

/retest-required

Remaining retests: 0 against base HEAD be976da and 2 for PR HEAD 06a725a in total

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Sep 9, 2025

/retest-required

Remaining retests: 0 against base HEAD be976da and 2 for PR HEAD 06a725a in total

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Sep 10, 2025

/retest-required

Remaining retests: 0 against base HEAD be976da and 2 for PR HEAD 06a725a in total

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Sep 10, 2025

/retest-required

Remaining retests: 0 against base HEAD be976da and 2 for PR HEAD 06a725a in total

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Sep 10, 2025

/retest-required

Remaining retests: 0 against base HEAD be976da and 2 for PR HEAD 06a725a in total

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 10, 2025 •
edited
Loading

@sebrandon1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-serial-techpreview f41da25 link true /test e2e-aws-serial-techpreview
ci/prow/okd-scos-e2e-aws-ovn 06a725a link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@everettraven
Copy link
Copy Markdown
Contributor

everettraven commented Sep 10, 2025

HyperShift jobs seemed to hit a snag with OLM catalogs that have brought them down. openshift/hypershift#6782 was recently merged as a workaround while the OLM team pursues the appropriate fixes.

This is a small unrelated change so I'm going to override the hypershift checks here.

/override ci/prow/e2e-aws-ovn-hypershift
/override ci/prow/e2e-aws-ovn-hypershift-conformance

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 10, 2025

@everettraven: Overrode contexts on behalf of everettraven: ci/prow/e2e-aws-ovn-hypershift, ci/prow/e2e-aws-ovn-hypershift-conformance

Details

In response to this:

HyperShift jobs seemed to hit a snag with OLM catalogs that have brought them down. openshift/hypershift#6782 was recently merged as a workaround while the OLM team pursues the appropriate fixes.

This is a small unrelated change so I'm going to override the hypershift checks here.

/override ci/prow/e2e-aws-ovn-hypershift
/override ci/prow/e2e-aws-ovn-hypershift-conformance

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot Bot merged commit e515d9c into openshift:master Sep 10, 2025
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@everettraven everettraven everettraven approved these changes

@jkyros jkyros Awaiting requested review from jkyros

Assignees

@JoelSpeed JoelSpeed

@everettraven everettraven

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sebrandon1 @JoelSpeed @openshift-bot @openshift-ci-robot @everettraven @openshift-merge-robot