Gate new authconfig fields with featuregate #2253
Conversation
Signed-off-by: Bryce Palmer <[email protected]>
Signed-off-by: Bryce Palmer <[email protected]>
Signed-off-by: Bryce Palmer <[email protected]>
…bdomain as Azure AKS doesn't seem to support the format libraries even though they were added in the 1.31 release of Kube. See prow job for failure: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_hypershift/5840/pull-ci-openshift-hypershift-main-e2e-aks/1904891653957619712 Signed-off-by: Bryce Palmer <[email protected]>
Signed-off-by: Bryce Palmer <[email protected]>
|
Hello @deads2k! Some important instructions when contributing to openshift/api: |
| @@ -89,7 +90,7 @@ type AuthenticationSpec struct { | |||
| // +listType=map | |||
| // +listMapKey=name | |||
| // +kubebuilder:validation:MaxItems=1 | |||
| // +openshift:enable:FeatureGate=ExternalOIDC | |||
| // +openshift:enable:FeatureGate=ExternalOIDC;ExternalOIDCAdditionMappings | |||
There was a problem hiding this comment.
operative bit here.
openshift-ci
bot
added
the
size/XXL
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@deads2k: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
#2234 merged with changes behind a gate. Closing this /close |
|
@everettraven: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
I heard a rumor that gating some new fields was causing trouble. I made an example showing how to have a field gated on A or B.
#2234