[CCXDEV-15259]: Promote InsightsOnDemandDataGather and InsightConfig feature gate to default

[opokornyy]

No description provided.

[openshift-ci]

Hello @opokornyy! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[opokornyy]

/test verify-feature-promotion

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[JoelSpeed]

@opokornyy Looking at the data, we have no testing on either metal or SNO, does this feature work on those platforms? Should we be adding testing for them?

[opokornyy]

@opokornyy Looking at the data, we have no testing on either metal or SNO, does this feature work on those platforms? Should we be adding testing for them?

We already have metal jobs configured (https://github.com/openshift/release/blob/b7a2a049dacad8d85b856238b0839bb7c276ca76/ci-operator/config/openshift/insights-operator/openshift-insights-operator-release-4.21__periodics.yaml#L329)
). However, I noticed they are missing from the dashboard. I initially thought this was because we were using baremetal instead of metal, so I renamed it, but they still don’t appear in Sippy. I am now trying to fix it... For SNO, we don’t have any tests yet. If required, we can add them.

[openshift-ci]

@opokornyy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp	3052b14	link	false	/test e2e-gcp
ci/prow/verify-crd-schema	5d11885	link	true	/test verify-crd-schema
ci/prow/minor-e2e-upgrade-minor	5d11885	link	true	/test minor-e2e-upgrade-minor
ci/prow/verify-feature-promotion	5d11885	link	true	/test verify-feature-promotion
ci/prow/okd-scos-e2e-aws-ovn	5d11885	link	false	/test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[opokornyy]

@opokornyy Looking at the data, we have no testing on either metal or SNO, does this feature work on those platforms? Should we be adding testing for them?

We already have metal jobs configured (https://github.com/openshift/release/blob/b7a2a049dacad8d85b856238b0839bb7c276ca76/ci-operator/config/openshift/insights-operator/openshift-insights-operator-release-4.21__periodics.yaml#L329) ). However, I noticed they are missing from the dashboard. I initially thought this was because we were using baremetal instead of metal, so I renamed it, but they still don’t appear in Sippy. I am now trying to fix it... For SNO, we don’t have any tests yet. If required, we can add them.

I was checking SNO cluster and the Insights Operator is running there by default, so I am also adding test runs for that platform.

[everettraven]

@opokornyy Thanks for looking into adding those. Both metal (all variants in the promotion requirements) and SNO tests are required.

[everettraven]

I also dealt with an issue recently where our results weren't showing up in Sippy. We had to make sure our releases section in our configuration for our periodics looked like: https://github.com/openshift/release/blob/531d4d22d226a93f395034cf0b811cd1a00784e1/ci-operator/config/openshift/cluster-authentication-operator/openshift-cluster-authentication-operator-release-4.21__periodics.yaml#L36-L45