[WIP] SPLAT-2206: Added AWS dedicated host support #2484

vr4manta · 2025-09-18T16:20:57Z

Changes

Added static Dedicated Host support for AWS machines
Updated feature gate owner to rvanderp3 and component to splat

openshift-ci-robot · 2025-09-18T16:21:02Z

@vr4manta: This pull request references SPLAT-2206 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

SPLAT-2206

Changes

Added static Dedicated Host support for AWS machines

Updated feature gate owner to rvanderp3 and component to splat

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-09-18T16:21:12Z

@vr4manta: This pull request references SPLAT-2206 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

SPLAT-2206

Changes

Added static Dedicated Host support for AWS machines

Updated feature gate owner to rvanderp3 and component to splat

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2025-09-18T16:21:13Z

Hello @vr4manta! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

JoelSpeed · 2025-09-18T16:28:44Z

Does this API already exist upstream in CAPA?

vr4manta · 2025-09-18T17:21:04Z

Does this API already exist upstream in CAPA?

@JoelSpeed Yes, this is already merged and pulled into OpenShift. Working on just the static version since dynamic is not finished upstream.

everettraven · 2025-09-18T19:33:49Z

/assign

openshift-ci · 2025-09-19T12:16:24Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from everettraven. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

everettraven · 2025-09-19T14:03:13Z

machine/v1beta1/types_awsprovider.go

+	// +kubebuilder:validation:Pattern=`^h-[0-9a-f]{17}$`
+	// +kubebuilder:validation:MaxLength=19
+	// +openshift:enable:FeatureGate=AWSDedicatedHosts
+	// +optional


Please include constraints, explained in plain sentences, in the GoDoc.

I'll update this.

everettraven · 2025-09-19T14:05:47Z

machine/v1beta1/types_awsprovider.go

+
+	// hostID specifies the Dedicated Host on which the instance must be started.
+	// This field is mutually exclusive with DynamicHostAllocation.
+	// +kubebuilder:validation:Pattern=`^h-[0-9a-f]{17}$`


While I know that this is a machine API and as such the validations run through a webhook, we no longer recommend the use of the kubebuilder:validation:Pattern marker and prefer using the kubebuilder:validation:XValidation marker to write CEL expressions with more user-friendly error messages than what would be returned by the pattern marker.

sure, i can make this change

everettraven · 2025-09-19T14:06:43Z

machine/v1beta1/types_awsprovider.go

+	// +kubebuilder:validation:MaxLength=19
+	// +openshift:enable:FeatureGate=AWSDedicatedHosts
+	// +optional
+	HostID *string `json:"hostID,omitempty"`


What is the difference between setting this to "" and omitting the field entirely?

There should be no difference. I would assume this field is not set if user not intending to place instances into a dedicated host.

If there is no difference, this should not be a pointer and should have a minimum length of 1. This is probably what the linter is complaining about.

Since this is validated by Go based webhooks, and not openapi, the linter is wrong on this one.

If we make this not a pointer, then the Go code has no way to know if this was deliberately set to "" or not. We don't want "" to be valid, so this needs to be a pointer so that we can check that.

In this case (and future cases like this in these providerspec APIs) we will want to make exceptions to the serialization rules on the linter.

We may want to even disable the serialization rules on these particular APIs somehow 🤔

Ah, I went into standard API review mode here and forgot this API is webhook validation 🤦

Thanks for catching that!

We may want to even disable the serialization rules on these particular APIs somehow

Can we do this via codegen configurations?

Can we do this via codegen configurations?

No, but we should be able to disable using the .golangci-lint.yaml config, ideally we could have a different config for the APIs that act like this, these MAPI ones aren't the only ones (e.g. the aggregated APIs we support too)

everettraven · 2025-09-19T14:09:32Z

machine/v1beta1/types_awsprovider.go

+	// hostAffinity specifies the dedicated host affinity setting for the instance.
+	// When HostAffinity is set to host, an instance started onto a specific host always restarts on the same host if stopped.
+	// When HostAffinity is set to default, and you stop and restart the instance, it can be restarted on any available host.
+	// When HostAffinity is defined, HostID is required.


Whether it is set to host or default, hostID will be required?

Also, when referring to a field use the serialized form of the field name as that is what end-users would be familiar with:

Suggested change

// When HostAffinity is defined, HostID is required.

// When HostAffinity is defined, hostID is required.

Yes, if hostID is set, this field will be could required. The idea was that if they do not set this field when hostID is set, it will default to host behavior.

To clarify, hostID is required when hostAffinity is set to host and should be forbidden otherwise?

everettraven · 2025-09-19T14:09:51Z

machine/v1beta1/types_awsprovider.go

+	// When HostAffinity is defined, HostID is required.
+	// +openshift:enable:FeatureGate=AWSDedicatedHosts
+	// +optional
+	HostAffinity *HostAffinity `json:"hostAffinity,omitempty"`


What happens if I don't supply this value?

It will default to host. I have been playing with trying to make linter happy with the configs today (which I put this into WIP). I will update the godoc to reflect this default behavior shortly.

So are the options here actually omitted (i.e don't set hostAffinity and hostID to use default AWS affinity logic) and Host (i.e I want it to use be assigned to this host)?

everettraven · 2025-09-19T14:12:37Z

machine/v1beta1/types_awsprovider.go

+	// hostAffinity specifies the dedicated host affinity setting for the instance.
+	// When HostAffinity is set to host, an instance started onto a specific host always restarts on the same host if stopped.
+	// When HostAffinity is set to default, and you stop and restart the instance, it can be restarted on any available host.
+	// When HostAffinity is defined, HostID is required.


For enum fields we generally try to follow the pattern of:

hostAffinity ...
Allowed values are Host, Default, and omitted.
When set to Host, ...
When set to Default, ...
When omitted, ...

Ok, i'll make this godoc update

everettraven · 2025-09-19T14:13:04Z

machine/v1beta1/types_awsprovider.go

 )
+
+// HostAffinity describes the host affinity of an EC2 Instance
+// +kubebuilder:validation:Enum:=host;default;""


Enums should be CamelCase:

Suggested change

// +kubebuilder:validation:Enum:=host;default;""

// +kubebuilder:validation:Enum:=Host;Default;""

I thought it should. I was copying what was in CAPA. I'll make these adjustments.

everettraven · 2025-09-19T14:13:52Z

machine/v1beta1/types_awsprovider.go

+// HostAffinity describes the host affinity of an EC2 Instance
+// +kubebuilder:validation:Enum:=host;default;""
+// +kubebuilder:default=""


How is setting "" different than omitting the field that uses this type altogether?

This was an attempt to make linter happy. I'll see if I can drop this which is what I am attempting.

openshift-ci · 2025-09-19T15:54:07Z

@vr4manta: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 18, 2025

openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 18, 2025

openshift-ci bot requested review from everettraven and JoelSpeed September 18, 2025 16:23

vr4manta force-pushed the SPLAT-2206 branch from 165b8e8 to 92afa52 Compare September 18, 2025 17:19

openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 18, 2025

vr4manta mentioned this pull request Sep 18, 2025

[WIP] SPLAT-2167: Added dedicated hosts support for AWS openshift/machine-api-operator#1419

Draft

openshift-ci bot assigned everettraven Sep 18, 2025

vr4manta changed the title ~~SPLAT-2206: Added AWS dedicated host support~~ [WIP] SPLAT-2206: Added AWS dedicated host support Sep 19, 2025

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 19, 2025

vr4manta force-pushed the SPLAT-2206 branch from 92afa52 to f9a28b8 Compare September 19, 2025 12:15

vr4manta force-pushed the SPLAT-2206 branch from f9a28b8 to 0fcff1c Compare September 19, 2025 12:38

Added AWS dedicated host support

b088b27

vr4manta force-pushed the SPLAT-2206 branch from 0fcff1c to b088b27 Compare September 19, 2025 13:33

everettraven reviewed Sep 19, 2025

View reviewed changes

	// When HostAffinity is defined, HostID is required.
	// When HostAffinity is defined, hostID is required.

	// +kubebuilder:validation:Enum:=host;default;""
	// +kubebuilder:validation:Enum:=Host;Default;""

[WIP] SPLAT-2206: Added AWS dedicated host support #2484

Are you sure you want to change the base?

[WIP] SPLAT-2206: Added AWS dedicated host support #2484

Conversation

vr4manta commented Sep 18, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

openshift-ci-robot commented Sep 18, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

openshift-ci-robot commented Sep 18, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

openshift-ci bot commented Sep 18, 2025

Uh oh!

JoelSpeed commented Sep 18, 2025

Uh oh!

vr4manta commented Sep 18, 2025

Uh oh!

everettraven commented Sep 18, 2025

Uh oh!

openshift-ci bot commented Sep 19, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vr4manta Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Sep 19, 2025

Uh oh!

Uh oh!

vr4manta commented Sep 18, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Sep 18, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Sep 18, 2025 •

edited by openshift-ci bot

Loading

vr4manta Sep 19, 2025 •

edited

Loading