Skip to content

Add IngressControllerConfig API for cluster-level ingress management #2485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add IngressControllerConfig API for cluster-level ingress management #2485

wants to merge 1 commit into from

Conversation

danielmellado
Copy link

Currently, OpenShift cluster administrators lack a unified way to
configure operational settings for ingress controllers across the
cluster. This introduces a new config/v1/IngressControllerConfig CRD
that provides cluster-wide configuration for resource management,
node scheduling, operational controls, and performance tuning.

Signed-off-by: Daniel Mellado [email protected]

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 19, 2025

Hello @danielmellado! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 19, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 19, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign everettraven for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@danielmellado
Copy link
Author

cc @joseorpa

@danielmellado danielmellado force-pushed the ingress_controller_resources branch from 8a27613 to 8d3af3a Compare September 19, 2025 09:37
JoelSpeed
JoelSpeed reviewed Sep 19, 2025
View reviewed changes
Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New APIs should be gated and introduced as v1alpha1 in the first instance, can you please add a feature gate, and move this initially to v1alpha1

@danielmellado danielmellado force-pushed the ingress_controller_resources branch from 8d3af3a to 329d2a6 Compare September 19, 2025 11:34
@danielmellado
Copy link
Author

@JoelSpeed would I need to create an enhancement to use a new FeatureGate or would it be ok to use legacyFeatureGateWithoutEnhancement? I assume it won't after 4.18 but would like an ack here. Thanks xD

@danielmellado
Copy link
Author

@joseorpa would you be the contact person for this? contactPerson("tbd").

@joseorpa
Copy link

Yes, I will be the owner

@JoelSpeed
Copy link
Contributor

An enhancement would be expected as well yes

@danielmellado
Add IngressControllerConfig API for cluster-level ingress management
d5cc1da 
Currently, OpenShift cluster administrators lack a unified way to
configure operational settings for ingress controllers across the
cluster. This introduces a new config/v1/IngressControllerConfig CRD
that provides cluster-wide configuration for resource management,
node scheduling, operational controls, and performance tuning.

Signed-off-by: Daniel Mellado <[email protected]>
@danielmellado danielmellado force-pushed the ingress_controller_resources branch from 329d2a6 to d5cc1da Compare September 19, 2025 12:05
@everettraven
Copy link
Contributor

/assign

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 19, 2025

@danielmellado: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/integration d5cc1da link true /test integration
ci/prow/verify d5cc1da link true /test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

everettraven
everettraven reviewed Sep 23, 2025
View reviewed changes
Copy link
Contributor

@everettraven everettraven left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving an initial high-level question

Feel free to ignore if the enhancement will answer it and let me know when the enhancement is ready for a read (the context helps in API reviews).

config/v1alpha1/types_ingress_controller.go
// +kubebuilder:resource:path=ingresscontrollerconfigs,scope=Cluster
// +kubebuilder:subresource:status
// +kubebuilder:metadata:annotations="description=Ingress Controller configuration API"
type IngressControllerConfig struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who/what is going to create this resource?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@JoelSpeed JoelSpeed JoelSpeed left review comments

@everettraven everettraven everettraven left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@everettraven everettraven

Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danielmellado @joseorpa @JoelSpeed @everettraven