Skip to content

Conversation

mdbooth
Copy link
Contributor

@mdbooth mdbooth commented Oct 15, 2025

make target which use codegen are ignoring the API_GROUP_VERSIONS
environment variable. e.g.:

$ make verify-codegen-crds API_GROUP_VERSIONS="operator.openshift.io/v1alpha1"

will run against all group/versions.

tools/Makefile contains a 'run-codegen' target which does reference
API_GROUP_VERSIONS, but nothing seems to call this. Instead they call
hack/update-codegen.sh, which does not use it.

This change updates hack/update-codegen.sh to add the same
--api-group-versions argument as 'run-codegen'.

make target which use codegen are ignoring the API_GROUP_VERSIONS
environment variable. e.g.:

  $ make verify-codegen-crds API_GROUP_VERSIONS="operator.openshift.io/v1alpha1"

will run against all group/versions.

tools/Makefile contains a 'run-codegen' target which does reference
API_GROUP_VERSIONS, but nothing seems to call this. Instead they call
hack/update-codegen.sh, which does not use it.

This change updates hack/update-codegen.sh to add the same
--api-group-versions argument as 'run-codegen'.
Copy link
Contributor

openshift-ci bot commented Oct 15, 2025

Hello @mdbooth! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 15, 2025
Copy link
Contributor

openshift-ci bot commented Oct 15, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Oct 15, 2025

@mdbooth: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify 8010a8b link true /test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@everettraven
Copy link
Contributor

curious why the verify check is failing - does it fail locally for you as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants