Skip to content

Conversation

@ricky-rav
Copy link

Using this as draft for the related openshift enhancement: openshift/enhancements#1859

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 17, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 17, 2025

Hello @ricky-rav! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 17, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 17, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JoelSpeed
Copy link
Contributor

@ricky-rav Is this ready for an initial round of API review?

@ricky-rav
Copy link
Author

ricky-rav commented Oct 22, 2025

@ricky-rav Is this ready for an initial round of API review?

No no, it was just a draft for myself to keep track of the API changes in an enhancement I'm writing. I think @pliurh is taking over the API part of the feature.

@openshift-ci openshift-ci bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 17, 2025
@ricky-rav ricky-rav changed the title [WIP] API for no-overlay mode in OVN-Kubernetes [WIP] API changes and feature gate for OVN-Kubernetes no-overlay mode Nov 17, 2025
@ricky-rav ricky-rav changed the title [WIP] API changes and feature gate for OVN-Kubernetes no-overlay mode CORENET-6390: API changes and feature gate for OVN-Kubernetes no-overlay mode Nov 17, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 17, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 17, 2025

@ricky-rav: This pull request references CORENET-6390 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Using this as draft for the related openshift enhancement: openshift/enhancements#1859

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

This commit introduces API changes to support OVN-Kubernetes no-overlay mode for the default network,
where the cluster default network operates without overlay encapsulation (Geneve).

API changes (operator.openshift.io/v1):
- Added defaultNetworkTransport field to OVNKubernetesConfig (NoOverlay or Geneve)
- Added defaultNetworkNoOverlayOptions with outboundSNAT and routing configuration
- Added bgpManagedConfig for BGP configuration when routing is managed
- All no-overlay fields are immutable after cluster creation

Added feature gate (TechPreviewNoUpgrade) for NoOverlayMode within the Networking/ovn-kubernetes component.

Ran these commands to update autogenerated source files:
$ hack/update-codegen-crds.sh
$ hack/update-swagger-docs.sh
$ hack/update-payload-featuregates.sh

Openshift enhancement for this feature: openshift/enhancements#1859

Signed-off-by: Riccardo Ravaioli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants