OCPBUGS-63311: config/v1/types_cluster_version: Tighten force and rollback warnings #2539
Conversation
openshift-ci-robot
added
jira/severity-low
|
@wking: This pull request references Jira Issue OCPBUGS-63311, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Hello @wking! Some important instructions when contributing to openshift/api: |
openshift-ci
bot
added
the
size/S
wking
force-pushed
the
tighten-cluster-version-force-docs
branch
from
e2ffa03 to
a20cc4f
Compare
openshift-ci
bot
added
size/M
wking
force-pushed
the
tighten-cluster-version-force-docs
branch
from
a20cc4f to
1cf10c3
Compare
openshift-ci
bot
added
size/L
wking
force-pushed
the
tighten-cluster-version-force-docs
branch
from
1cf10c3 to
b618d5b
Compare
Apparently our existing wording is not sufficient to convince external customers that forcing a rollback is a risky move. Tighten the wording to try to be even more clear about the potential downsides. The guards force blasts through are designed to keep you safe!
|
/lgtm No need to run verification on docs only changes |
openshift-ci-robot
added
the
verified
|
@JoelSpeed: The In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@wking: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@wking: Jira Issue Verification Checks: Jira Issue OCPBUGS-63311 Jira Issue OCPBUGS-63311 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Fix included in accepted release 4.21.0-0.nightly-2025-10-19-181151 |
Pulling in [1]. Generated with:
$ go get github.com/openshift/api@master
$ go get github.com/openshift/client-go@master
$ go get github.com/openshift/library-go@master
$ go mod tidy
$ go mod vendor
$ git add -A go.* vendor
using:
$ go version
go version go1.24.0 linux/amd64
The client-go import addresses:
go: finding module for package k8s.io/api/networking/v1alpha1
go: github.com/openshift/cluster-version-operator/pkg/cvo imports
k8s.io/client-go/kubernetes/scheme imports
k8s.io/api/networking/v1alpha1: module k8s.io/api@latest found (v0.34.1), but does not contain package k8s.io/api/networking/v1alpha1
The library-go update is just a "while I'm at it..." bump to round out
the openshift/ dependencies.
[1]: openshift/api#2539
Pulling in [1]. Generated with:
$ go get github.com/openshift/api@master
$ go get github.com/openshift/client-go@master
$ go get github.com/openshift/library-go@master
$ go mod tidy
$ go mod vendor
$ git add -A go.* vendor
using:
$ go version
go version go1.24.0 linux/amd64
The client-go import addresses:
$ go mod tidy
...
go: finding module for package k8s.io/api/networking/v1alpha1
go: github.com/openshift/cluster-version-operator/pkg/cvo imports
k8s.io/client-go/kubernetes/scheme imports
k8s.io/api/networking/v1alpha1: module k8s.io/api@latest found (v0.34.1), but does not contain package k8s.io/api/networking/v1alpha1
The library-go update is just a "while I'm at it..." bump to round out
the openshift/ dependencies.
[1]: openshift/api#2539
Catching the --help and stderr warnings for --force up with the recent openshift/api@b618d5bd8c (config/v1/types_cluster_version: Tighten force and rollback warnings, 2025-10-18, openshift/api#2539) wording.
Catching the --help and stderr warnings for --force up with the recent openshift/api@b618d5bd8c (config/v1/types_cluster_version: Tighten force and rollback warnings, 2025-10-18, openshift/api#2539) wording.
|
Fix included in accepted release 4.21.0-0.nightly-2025-11-05-234508 |
|
Does this pick cleanly? |
|
@sdodson: cannot checkout In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Catching the --help and stderr warnings for --force up with the recent openshift/api@b618d5bd8c (config/v1/types_cluster_version: Tighten force and rollback warnings, 2025-10-18, openshift/api#2539) wording.
|
/cherry-pick release-4.20 |
|
@sdodson: new pull request created: #2581 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
6 participants
Apparently our existing wording is not sufficient to convince external customers that forcing a rollback is a risky move. Tighten the wording to try to be even more clear about the potential downsides. The guards force blasts through are designed to keep you safe!