[release-4.18] CNTRLPLANE-1980: Promote streaming list encoding to Default #2598
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
openshift-ci-robot
added
the
jira/valid-reference
|
@rh-roman: This pull request references CNTRLPLANE-1980 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
|
/hold |
|
Hello @rh-roman! Some important instructions when contributing to openshift/api: |
openshift-ci
bot
added
do-not-merge/hold
|
/payload 4.18 nightly blocking |
|
@rh-roman: trigger 12 job(s) of type blocking for the nightly release of OCP 4.18
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/9b27fa40-cfa4-11f0-81ff-2e60786fb27c-0 |
|
/retest-required |
|
/payload-job periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-aws-ovn-conformance |
|
@rh-roman: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/482aea20-d092-11f0-83f6-2851a233d398-0 |
|
On the initial run, 3 jobs failed Microshift payload jobs don't work #2597 (comment)
|
Change ovn-kubernetes master build_root from golang-1.22 to rhel-9-release-golang-1.24-openshift-4.18 to provide dev tools (git, jq, ssh) needed by microshift conformance tests when they run as payload qualifiers. When microshift periodic tests run as payload qualifiers (via /payload or release-controller), ci-operator merges configs: Base: openshift/ovn-kubernetes@master (provides build_root) Injected: openshift/[email protected]__periodics:e2e-aws-ovn-ocp-conformance-serial The microshift workflow steps use "from: root" which resolves to the merged config's build_root. The plain golang-1.22 image lacks dev tools that microshift test scripts require, causing "unknown image root" errors. The rhel-9-release-golang image provides both golang and dev tools, working for both ovn-kubernetes's own tests (which use "from: src") and injected microshift tests (which use "from: root"). Fixes: - periodic-ci-openshift-microshift-release-4.21-periodics-e2e-aws-ovn-ocp-conformance - periodic-ci-openshift-microshift-release-4.21-periodics-e2e-aws-ovn-ocp-conformance-serial Related: openshift/ovn-kubernetes#2887 Related: openshift/api#2598
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/lgtm /hold Should we wait for 4.19 to hit a green payload before merging this? |
openshift-ci
bot
added
jira/valid-bug
|
/label backport-risk-assessed |
openshift-ci
bot
added
the
backport-risk-assessed
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
I see it in https://amd64.ocp.releases.ci.openshift.org/releasestream/4-stable/release/4.19.19 now. /hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest-required |
|
/pipeline required |
|
/test e2e-aws-ovn-hypershift-conformance |
|
@liangxia: The specified target(s) for The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test e2e-aws-serial |
|
/test e2e-aws-serial-techpreview |
|
@rh-roman: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
8 participants
Promote streaming list encoding from only being on by default in Hypershift to being on by default everywhere.