-
Notifications
You must be signed in to change notification settings - Fork 581
NO-JIRA: remove beta enabled TranslateStreamCloseWebsocketRequests feature from gates #2613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
NO-JIRA: remove beta enabled TranslateStreamCloseWebsocketRequests feature from gates #2613
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@geoberle: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughRemoved the TranslateStreamCloseWebsocketRequests feature gate from documentation, its Go declaration, and from multiple feature-gate manifest files for Hypershift and SelfManagedHA configurations. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Cache: Disabled due to data retention organization setting Knowledge base: Disabled due to 📒 Files selected for processing (8)
💤 Files with no reviewable changes (8)
Comment |
|
Hello @geoberle! Some important instructions when contributing to openshift/api: |
|
/lgtm |
|
/lgtm /label acknowledge-critical-fixes-only |
|
Scheduling tests matching the |
|
/retest-required |
…ature from gates the `TranslateStreamCloseWebsocketRequests` feature is beta enabled in 1.30 Signed-off-by: Gerd Oberlechner <[email protected]>
e8c6c8e to
887fcda
Compare
|
/lgtm |
|
Scheduling tests matching the |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed, tkashem The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-upgrade |
|
/retest-required |
|
@geoberle: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@geoberle Have you been able to test that this behaves as you're expecting? We need to add the verified label for this to merge and for that we are expecting someone has manually tested this |
the
TranslateStreamCloseWebsocketRequestsfeature is beta enabled in 1.30https://github.com/openshift/kubernetes/blob/0987ea121e432412b7582943a195708e67e0a38f/pkg/features/kube_features.go#L1828-L1831