OCPBUGS-81880: Mark raw FC/iSCSI multipath members as ineligible

[yoavsc0302]

Manual cherry-pick of #10142 to release-4.20, Two commits:

1. Revert PR OCPBUGS-81880: Prefer multipath disk in ABI disk selection #10111 — The GetPreferredDiskID approach is bypassed by the "already matches" early return in
   applyRootDeviceHints(): if Phase 1 auto-selects a raw FC/iSCSI path and it appears in the acceptable disk list,
   the function returns before GetPreferredDiskID is ever called. Confirmed on s390x FC multipath hardware.

2. Mark raw FC/iSCSI multipath members as ineligible — Raw FC and iSCSI disks that are members of a multipath
   device are now marked as ineligible at the validator level. Writing to a raw path instead of the multipath device
   causes installation failure (ENODEV) when multipathd reclaims the disk. By making them ineligible at the source,
   they are filtered out from all disk selection paths (SaaS, ZTP, ABI), no bypass is possible, and they show as
   ineligible in the UI with a clear reason.

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 57e57b5c-fa43-4538-a82b-029bf7b9f6cf

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci-robot]

@yoavsc0302: This pull request references Jira Issue OCPBUGS-81880, which is invalid:

• expected dependent Jira Issue OCPBUGS-81843 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ASSIGNED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Manual cherry-pick of #10142 to release-4.20, Two commits:

1. Revert PR OCPBUGS-81880: Prefer multipath disk in ABI disk selection #10111 — The GetPreferredDiskID approach is bypassed by the "already matches" early return in
   applyRootDeviceHints(): if Phase 1 auto-selects a raw FC/iSCSI path and it appears in the acceptable disk list,
   the function returns before GetPreferredDiskID is ever called. Confirmed on s390x FC multipath hardware.

2. Mark raw FC/iSCSI multipath members as ineligible — Raw FC and iSCSI disks that are members of a multipath
   device are now marked as ineligible at the validator level. Writing to a raw path instead of the multipath device
   causes installation failure (ENODEV) when multipathd reclaims the disk. By making them ineligible at the source,
   they are filtered out from all disk selection paths (SaaS, ZTP, ABI), no bypass is possible, and they show as
   ineligible in the UI with a clear reason.

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yoavsc0302

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [yoavsc0302]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@yoavsc0302: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[zaneb]

/lgtm
/label backport-risk-assessed