Skip to content

[release-4.22] OCPBUGS-83542: Mark raw FC/iSCSI multipath members as ineligible#10150

Open
openshift-cherrypick-robot wants to merge 2 commits intoopenshift:release-4.22from
openshift-cherrypick-robot:cherry-pick-10142-to-release-4.22
Open

[release-4.22] OCPBUGS-83542: Mark raw FC/iSCSI multipath members as ineligible#10150
openshift-cherrypick-robot wants to merge 2 commits intoopenshift:release-4.22from
openshift-cherrypick-robot:cherry-pick-10142-to-release-4.22

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

@openshift-cherrypick-robot openshift-cherrypick-robot commented Apr 15, 2026

This is an automated cherry-pick of #10142

/assign yoavsc0302

/cherrypick release-4.21 release-4.20

@yoavsc0302
Revert "OCPBUGS-79576: Prefer multipath disk in ABI disk selection"
4330710 
This reverts merge commit a63f435 (PR openshift#10091).

The GetPreferredDiskID approach is bypassed by the "already matches"
short-circuit in applyRootDeviceHints: if the service auto-selected
a raw FC/iSCSI path and it appears in the acceptable list, the code
returns early without ever calling GetPreferredDiskID.

The correct fix is to mark raw FC/iSCSI multipath members as
ineligible at the validator level (next commit).
@yoavsc0302
OCPBUGS-79576: Mark raw FC/iSCSI multipath members as ineligible
abf2b5f 
Raw FC and iSCSI disks that are members of a multipath device are
not eligible for installation. Writing to a raw path instead of the
multipath device causes installation failure (ENODEV) when multipathd
reclaims the disk.

Mark these disks as ineligible at the validator level so they are
excluded from all disk selection paths (SaaS, ZTP, ABI) and show
as ineligible in the UI.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 15, 2026
Merged
20 tasks
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 15, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 379233e2-7d98-4d49-b0e1-451b6af657ff

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 15, 2026
@openshift-ci openshift-ci Bot requested review from danmanor and zaneb April 15, 2026 18:17
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 15, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign maorfr for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 15, 2026

@openshift-cherrypick-robot: Jira Issue OCPBUGS-79576 has been cloned as Jira Issue OCPBUGS-83542. Will retitle bug to link to clone.
/retitle [release-4.22] OCPBUGS-83542: Mark raw FC/iSCSI multipath members as ineligible

Details

In response to this:

This is an automated cherry-pick of #10142

/assign yoavsc0302

/cherrypick release-4.21 release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot changed the title [release-4.22] OCPBUGS-79576: Mark raw FC/iSCSI multipath members as ineligible [release-4.22] OCPBUGS-83542: Mark raw FC/iSCSI multipath members as ineligible Apr 15, 2026
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 15, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 15, 2026

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-83542, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #10142

/assign yoavsc0302

/cherrypick release-4.21 release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 15, 2026

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@zaneb
Copy link
Copy Markdown
Member

zaneb commented Apr 15, 2026

/lgtm
/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 15, 2026
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2026
@yoavsc0302
Copy link
Copy Markdown
Contributor

yoavsc0302 commented Apr 16, 2026

/jira refresh

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 16, 2026

@yoavsc0302: This pull request references Jira Issue OCPBUGS-83542, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@yoavsc0302
Copy link
Copy Markdown
Contributor

yoavsc0302 commented Apr 16, 2026

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 16, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 16, 2026

@yoavsc0302: This pull request references Jira Issue OCPBUGS-83542, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-79576 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-79576 targets the "4.23.0" version, which is one of the valid target versions: 4.23.0
  • bug has dependents
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danmanor danmanor Awaiting requested review from danmanor

@zaneb zaneb Awaiting requested review from zaneb

Assignees

@zaneb zaneb

@yoavsc0302 yoavsc0302

Labels

backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@openshift-cherrypick-robot @openshift-ci-robot @zaneb @yoavsc0302